Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature client transfer #411

Merged
merged 16 commits into from
May 18, 2020
Merged

Feature client transfer #411

merged 16 commits into from
May 18, 2020

Conversation

kjgarza
Copy link
Contributor

@kjgarza kjgarza commented May 12, 2020

Purpose

Allows staff admin to transfer repositories

resolves: #404

Approach

Adds a component to transfer repository.
It also renames the repository-transfer component as repository-dois-transfer to better fit its Purpose.

Learning

Fabrica stays in cache for a long time sometimes.

Status

  • Ready for Review

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@kjgarza kjgarza changed the title Feature client transfer WIP: Feature client transfer May 12, 2020
@kjgarza kjgarza self-assigned this May 12, 2020
@kjgarza kjgarza changed the title WIP: Feature client transfer Feature client transfer May 15, 2020
@kjgarza kjgarza requested a review from mfenner May 15, 2020 10:24
Copy link
Contributor

@mfenner mfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why we have both repository-transfer and repository-dois-transfer components? I am also not convinced that we have a repository-dois transfer, at least for the user it is a transfer of the repository, the reindexing of DOIs is needed but for me not essential for what we are doing in the DOI.

Looks good otherwise.

@kjgarza
Copy link
Contributor Author

kjgarza commented May 18, 2020

as mentioned in the purpose, it just a refactor of the component to transfer dois:

It also renames the repository-transfer component as repository-dois-transfer to better fit its purpose.

One component its for the transfer doi functionality (the old/refactored one) and the new one is for transferring repositories.

@mfenner
Copy link
Contributor

mfenner commented May 18, 2020

Why not repository-transfer and doi-transfer. That is what the user sees in the UI. As repository-transfer does not transfer any DOIs.

@kjgarza
Copy link
Contributor Author

kjgarza commented May 18, 2020

doi-transfer already exists, remember? https://github.com/datacite/bracco/blob/master/app/components/doi-transfer.js that's for the transfer of a DOI. it's for a single doi.

repository-dois-transfer is the old component that transfers all the dois of a single repository.

repository-dois-transfer shows:
https://doi.datacite.org/repositories/rads.sch/transfer

while repository-transfer shows:
https://codepen.io/kjgarza/full/YzyNxLg

@mfenner
Copy link
Contributor

mfenner commented May 18, 2020

@kjgarza thanks for clarifying that, this makes sense.

Copy link
Contributor

@mfenner mfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjgarza kjgarza merged commit e849e78 into master May 18, 2020
@mfenner mfenner deleted the feature_client_transfer branch February 3, 2021 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Transfer Prefix functionality in Fabrica
2 participants