Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let migration status test assert all migration statuses #1667

Merged
merged 1 commit into from
May 8, 2024

Conversation

JCZuurmond
Copy link
Member

@JCZuurmond JCZuurmond commented May 8, 2024

Changes

  • Test there are any migration statuses
  • Log migration statuses with test failure

Linked issues

In addition to #1651, hopefully provides more information for #1615

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs ucx ...
  • added a new workflow
  • modified existing workflow: ...
  • added a new table
  • modified existing table: ...

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • verified on staging environment (screenshot attached)

@JCZuurmond JCZuurmond requested review from a team and dleiva04 May 8, 2024 13:23
@JCZuurmond JCZuurmond requested a review from nkvuong May 8, 2024 13:23
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.35%. Comparing base (7f0b778) to head (f9e1e18).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1667      +/-   ##
==========================================
- Coverage   88.36%   88.35%   -0.01%     
==========================================
  Files          87       87              
  Lines       10899    10899              
  Branches     1923     1923              
==========================================
- Hits         9631     9630       -1     
  Misses        900      900              
- Partials      368      369       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JCZuurmond JCZuurmond force-pushed the fix/test-table-migration-status-verify-all-statuses branch from bf476db to 9e59c48 Compare May 8, 2024 13:33
@nkvuong nkvuong enabled auto-merge May 8, 2024 13:51
Copy link

github-actions bot commented May 8, 2024

✅ 164/164 passed, 25 skipped, 2h24m43s total

Running from acceptance #3090

@nkvuong nkvuong added this pull request to the merge queue May 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2024
@JCZuurmond JCZuurmond enabled auto-merge May 8, 2024 14:22
@JCZuurmond JCZuurmond force-pushed the fix/test-table-migration-status-verify-all-statuses branch from 9e59c48 to f9e1e18 Compare May 8, 2024 14:22
Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nfx nfx merged commit 894cea4 into main May 8, 2024
7 of 8 checks passed
@nfx nfx deleted the fix/test-table-migration-status-verify-all-statuses branch May 8, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants