Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let migration status test have one assert #1651

Merged
merged 2 commits into from
May 7, 2024

Conversation

JCZuurmond
Copy link
Member

@JCZuurmond JCZuurmond commented May 7, 2024

Changes

Reqwrite migration status test to have one assert in an attempt to better understand when it fails.

Linked issues

Hopefully provides more information for #1615

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs ucx ...
  • added a new workflow
  • modified existing workflow: ...
  • added a new table
  • modified existing table: ...

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • verified on staging environment (screenshot attached)

@JCZuurmond JCZuurmond requested review from a team and mwojtyczka May 7, 2024 12:18
@JCZuurmond JCZuurmond force-pushed the fix/have-one-assert-in-tables-migration-status-test branch from 78f8aed to f67dece Compare May 7, 2024 12:19
@JCZuurmond JCZuurmond requested a review from nkvuong May 7, 2024 12:20
@JCZuurmond JCZuurmond removed the request for review from mwojtyczka May 7, 2024 12:20
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (0a47514) to head (f67dece).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1651   +/-   ##
=======================================
  Coverage   90.10%   90.10%           
=======================================
  Files          86       86           
  Lines       10568    10568           
  Branches     1863     1863           
=======================================
  Hits         9522     9522           
  Misses        684      684           
  Partials      362      362           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JCZuurmond JCZuurmond enabled auto-merge May 7, 2024 12:22
Copy link

github-actions bot commented May 7, 2024

✅ 160/160 passed, 1 flaky, 25 skipped, 2h0m58s total

Flaky tests:

  • 🤪 test_table_migration_job_refreshes_migration_status[regular-migrate-tables] (3m35.462s)

Running from acceptance #3008

@JCZuurmond JCZuurmond added this pull request to the merge queue May 7, 2024
@nkvuong nkvuong removed this pull request from the merge queue due to a manual request May 7, 2024
@nkvuong nkvuong added this pull request to the merge queue May 7, 2024
@nfx nfx removed this pull request from the merge queue due to a manual request May 7, 2024
@nfx nfx merged commit c79c9aa into main May 7, 2024
8 checks passed
@nfx nfx deleted the fix/have-one-assert-in-tables-migration-status-test branch May 7, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants