-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement rolling().count() in Series and Frame #990
Conversation
Codecov Report
@@ Coverage Diff @@
## master #990 +/- ##
==========================================
- Coverage 94.84% 94.79% -0.06%
==========================================
Files 34 34
Lines 6519 6586 +67
==========================================
+ Hits 6183 6243 +60
- Misses 336 343 +7
Continue to review full report at Codecov.
|
Let's fix expanding ones first, and them get those in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise.
Softagram Impact Report for pull/990 (head commit: 7d07d7e)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as #996. Otherwise LGTM.
This PR implements rolling().count():
Relates to #977