Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rolling().count() in Series and Frame #990

Merged
merged 7 commits into from
Nov 6, 2019

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Nov 1, 2019

This PR implements rolling().count():

>>> import databricks.koalas as ks
>>> s = ks.Series([2, 3, float("nan"), 10])
>>> s.rolling(1).count()
0    1.0
1    1.0
2    0.0
3    1.0
Name: 0, dtype: float64

>>> s.to_frame().rolling(1).count()
     0
0  1.0
1  1.0
2  0.0
3  1.0

Relates to #977

@codecov-io
Copy link

codecov-io commented Nov 1, 2019

Codecov Report

Merging #990 into master will decrease coverage by 0.05%.
The diff coverage is 97.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #990      +/-   ##
==========================================
- Coverage   94.84%   94.79%   -0.06%     
==========================================
  Files          34       34              
  Lines        6519     6586      +67     
==========================================
+ Hits         6183     6243      +60     
- Misses        336      343       +7
Impacted Files Coverage Δ
databricks/koalas/missing/window.py 100% <ø> (ø) ⬆️
databricks/koalas/generic.py 95.73% <ø> (-0.44%) ⬇️
databricks/koalas/groupby.py 91.39% <100%> (ø) ⬆️
databricks/koalas/window.py 92.48% <97.22%> (-0.38%) ⬇️
databricks/koalas/indexes.py 96.25% <0%> (-0.38%) ⬇️
databricks/koalas/utils.py 98.02% <0%> (ø) ⬆️
databricks/koalas/missing/series.py 100% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b161428...7d07d7e. Read the comment docs.

@HyukjinKwon
Copy link
Member

Let's fix expanding ones first, and them get those in.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise.

@softagram-bot
Copy link

Softagram Impact Report for pull/990 (head commit: 7d07d7e)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as #996. Otherwise LGTM.

@HyukjinKwon HyukjinKwon merged commit 9aba8ae into databricks:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants