-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement min, max, sum and mean of Rolling in Series and DataFrame #996
Implement min, max, sum and mean of Rolling in Series and DataFrame #996
Conversation
Codecov Report
@@ Coverage Diff @@
## master #996 +/- ##
=========================================
Coverage ? 92.46%
=========================================
Files ? 34
Lines ? 6698
Branches ? 0
=========================================
Hits ? 6193
Misses ? 505
Partials ? 0
Continue to review full report at Codecov.
|
4 13.0 65.0 | ||
""" | ||
def sum(scol): | ||
window = Window.orderBy(self._index_scols) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this into _apply_as_series_or_frame
and use self._window
? We can match the implementation into Expanding one I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HyukjinKwon
Thanks for the comment!
but maybe is it possible although this window
and self._window
are used for different purpose like below?
i think to calculate F.lag(scol, self._window_val).over(window) >= self._min_periods
, we need another window rather than self._window
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine otherwise.
@itholic can you rebase please? |
@HyukjinKwon sure, i just did. |
Softagram Impact Report for pull/996 (head commit: 364254c)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
Let me clean up by myself. merged |
@HyukjinKwon Thanks :) |
This PR implement min, max, sum and mean of Rolling in Series and DataFrame
For Series:
For DataFrame
relates to #977