Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified PlotAccessor for DataFrame and Series #1662

Merged
merged 16 commits into from
Aug 12, 2020
Merged

Unified PlotAccessor for DataFrame and Series #1662

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ea3fef7
intial support for unified PlotAccessor via new_plot method
DumbMachine Jul 17, 2020
e335e31
added PlotAccessor
DumbMachine Jul 17, 2020
c859615
removed new_plot.py
DumbMachine Jul 17, 2020
6ff23c4
minor format changes
DumbMachine Jul 22, 2020
7d09567
ran dev/reformat
DumbMachine Jul 22, 2020
59a2d40
flake8 passing
DumbMachine Jul 22, 2020
3a38360
format changes and renamed PlotAccessor to KoalasPlotAccessor
DumbMachine Jul 22, 2020
41e5083
ran dev/reformat again
DumbMachine Jul 22, 2020
cef62ac
Fix.
ueshin Jul 22, 2020
4e72433
Merge pull request #2 from ueshin/plot
DumbMachine Jul 22, 2020
0dfa15b
tests rerun
DumbMachine Jul 22, 2020
665ce26
added docstrings for Series and Dataframe
DumbMachine Aug 10, 2020
5397e66
lint changes
DumbMachine Aug 10, 2020
8bdabc7
linting doc strings
DumbMachine Aug 10, 2020
5ed1307
reverting doc for hist
DumbMachine Aug 11, 2020
cbc17d5
added a newline in hist doc
DumbMachine Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions databricks/koalas/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
from databricks.koalas.missing.frame import _MissingPandasLikeDataFrame
from databricks.koalas.ml import corr
from databricks.koalas.typedef import infer_return_type, as_spark_type, DataFrameType, SeriesType
from databricks.koalas.plot import KoalasFramePlotMethods
from databricks.koalas.plot import KoalasPlotAccessor

# These regular expression patterns are complied and defined here to avoid to compile the same
# pattern every time it is used in _repr_ and _repr_html_ in DataFrame.
Expand Down Expand Up @@ -806,7 +806,7 @@ def add(self, other):
return self + other

# create accessor for plot
plot = CachedAccessor("plot", KoalasFramePlotMethods)
plot = CachedAccessor("plot", KoalasPlotAccessor)

# create accessor for Spark related methods.
spark = CachedAccessor("spark", SparkFrameMethods)
Expand All @@ -817,12 +817,12 @@ def add(self, other):
def hist(self, bins=10, **kwds):
return self.plot.hist(bins, **kwds)

hist.__doc__ = KoalasFramePlotMethods.hist.__doc__
hist.__doc__ = KoalasPlotAccessor.hist.__doc__

def kde(self, bw_method=None, ind=None, **kwds):
return self.plot.kde(bw_method, ind, **kwds)

kde.__doc__ = KoalasFramePlotMethods.kde.__doc__
kde.__doc__ = KoalasPlotAccessor.kde.__doc__

add.__doc__ = _flex_doc_FRAME.format(
desc="Addition", op_name="+", equiv="dataframe + other", reverse="radd"
Expand Down
Loading