-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified PlotAccessor
for DataFrame and Series
#1662
Conversation
Could anybody help me with the PIP tests error? I do not get any error during local testing. |
I submitted a PR to you branch DumbMachine#2. |
Fix format.
@DumbMachine Could you push an empty commit to run tests again? |
PlotAccessor
for DataFrame and SeriesPlotAccessor
for DataFrame and Series
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM.
@DumbMachine Great work!
databricks/koalas/plot.py
Outdated
return unsupported_function(class_name="pd.DataFrame", method_name=kind)() | ||
return plot_frame(data=self.data, kind=kind, **kwds) | ||
|
||
__call__.__doc__ = plot_frame.__doc__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HyukjinKwon What do you think the doc should be if we consolidate the plotting classes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't built it and checked by myself but I think it's okay to consolidate in general.
if isinstance(self.data, Series): | ||
return self(kind="box", **kwds) | ||
elif isinstance(self.data, DataFrame): | ||
return unsupported_function(class_name="pd.DataFrame", method_name="box")() | ||
|
||
def hist(self, bins=10, **kwds): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move the example for DataFrame
?
@DumbMachine Could you address my comments above? |
Sorry for the delay, have made the changes. I will modify if any further changes are required, |
Thanks! merging. |
Aims to fix #1661
New
PlotAccessor
works the same way as the old.TODO:
docs
Examples:
<databricks.koalas.plot.PlotAccessor object at 0x7f32d669b590>
<databricks.koalas.plot.PlotAccessor object at 0x7f32cdffd750>
Error are handled, same as before
And finally