Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: leave all un-committed data to purge/vacuum #15535

Merged
merged 2 commits into from
May 15, 2024

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented May 15, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

instead of purging un-committed data of failed txn, leave them to purge/vacuum

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label May 15, 2024
@dantengsky dantengsky force-pushed the chore-disable-rollback branch 3 times, most recently from a2b6365 to ff76be7 Compare May 15, 2024 12:19
@dantengsky dantengsky force-pushed the chore-disable-rollback branch from ff76be7 to 3f20335 Compare May 15, 2024 12:25
@dantengsky dantengsky marked this pull request as ready for review May 15, 2024 13:35
@dantengsky dantengsky force-pushed the chore-disable-rollback branch from 88af9ec to 033529e Compare May 15, 2024 14:29
@dantengsky dantengsky added this pull request to the merge queue May 15, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request May 15, 2024
@BohuTANG BohuTANG merged commit 26a9ae9 into databendlabs:main May 15, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants