chore: log update_table_meta failure

databendlabs · May 15, 2024 · 033529e · 033529e
1 parent 3f20335
commit 033529e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/common/storage/src/parquet_rs.rs b/src/common/storage/src/parquet_rs.rs
@@ -93,6 +93,7 @@ pub async fn read_metadata_async(
         None => operator.stat(path).await?.content_length(),
         Some(n) => n,
     };
+
     check_footer_size(file_size)?;
 
     // read and cache up to DEFAULT_FOOTER_READ_SIZE bytes from the end and process the footer

diff --git a/src/query/storages/fuse/src/operations/commit.rs b/src/query/storages/fuse/src/operations/commit.rs
@@ -159,15 +159,18 @@ impl FuseTable {
             None,
         )
         .await;
+
         if need_to_save_statistics {
             let table_statistics_location: String = table_statistics_location.unwrap();
-            if res.is_ok() {
-                TableSnapshotStatistics::cache().put(
+            match &res {
+                Ok(_) => TableSnapshotStatistics::cache().put(
                     table_statistics_location,
                     Arc::new(table_statistics.unwrap()),
-                )
+                ),
+                Err(e) => info!("update_table_meta failed. {}", e),
             }
         }
+
         res
     }