chore: new setting create_rpc_client_with_current_rt
#13898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
dantengsky
force-pushed
the
chore-new-setting-create_rpc_client_with_current_rt
branch
2 times, most recently
from
f0a5f13 to
41e2f3d
Compare
dantengsky
force-pushed
the
chore-new-setting-create_rpc_client_with_current_rt
branch
from
41e2f3d to
f8e205c
Compare
zhang2014
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
As @zhang2014 suggested, a new setting
create_rpc_client_with_current_rtis introduced in this PR:nothing changed.
GlobalIORuntimewill be used, during creating flight client in exchange managerThis allows us for the adjustments made in datafuselabs/databend#13866 to be toggled off during runtime.
This change is