fix: resolve flight connection leak #13866
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Execution of distributed tasks may result in a leak of Flight TCP connections.
How to reproduce:
3 node cluster (local fs storage)
set up test data
create table t as select * from numbers(10000000)
execute the following script several times (typically, 10 times is sufficent)
turns out the primary reason for the Flight RPC connection leak is the mismatch between runtimes:
the runtime used to create the FlightClient and the one used to drop it are not the same.
Note: I cannot confirm that this completely resolves all issues related to Flight connection leaks.
This PR that havs been tested through the following scenarios:
conducted over approximately 12 hours, ec2 + s3, 3 node cluster
These tests show that the number of open file descriptors is under controlled.
This change is