Skip to content

Use new logo in performance reports #6515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jrbourbeau wants to merge 1 commit into from
Closed

Use new logo in performance reports #6515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion distributed/dashboard/templates/performance_report.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
{# See https://github.com/bokeh/bokeh/blob/main/bokeh/core/_templates/file.html #}

{% block preamble %}
<link rel="shortcut icon" href="https://docs.dask.org/en/latest/_static/images/favicon.ico" />
<link rel="shortcut icon" href="https://docs.dask.org/en/latest/_static/images/favicon.svg" />
Copy link
Member Author

@jrbourbeau jrbourbeau Jun 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I'm not sure why there's no longer a static favicon.ico file in this location. However, after looking at dask/dask-sphinx-theme#67, it appears we're putting favicon.svg here so I updated this logic to use that file instead. I confirmed the new logo is used when I locally produce a performance report.

{% endblock %}