Skip to content

Conversation

@jrbourbeau
Copy link
Member

This updates the favicon used in our performance reports to use our new logo

cc @jacobtomlinson @scharlottej13


{% block preamble %}
<link rel="shortcut icon" href="https://docs.dask.org/en/latest/_static/images/favicon.ico" />
<link rel="shortcut icon" href="https://docs.dask.org/en/latest/_static/images/favicon.svg" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I'm not sure why there's no longer a static favicon.ico file in this location. However, after looking at dask/dask-sphinx-theme#67, it appears we're putting favicon.svg here so I updated this logic to use that file instead. I confirmed the new logo is used when I locally produce a performance report.

@mrocklin
Copy link
Member

mrocklin commented Jun 6, 2022

Can we also replace the old .ico file? This might have been used elsewhere.

@jrbourbeau
Copy link
Member Author

Fair point. That would fix the issue with performance reports, and possibly other places too. I'm not sure where the .ico file is being produced -- @scharlottej13 perhaps you have some insight here?

@scharlottej13
Copy link
Contributor

Fair point. That would fix the issue with performance reports, and possibly other places too. I'm not sure where the .ico file is being produced -- @scharlottej13 perhaps you have some insight here?

I think it also comes from the dask-sphinx-theme-- I can update this!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

Unit Test Results

       15 files  +       3         15 suites  +3   6h 12m 14s ⏱️ + 1h 39m 44s
  2 841 tests ±       0    2 759 ✔️ +     13    81 💤  -   13  1 +1 
21 051 runs  +4 030  20 102 ✔️ +3 921  948 💤 +109  1 +1 

For more details on these failures, see this check.

Results for commit f1c7d15. ± Comparison against base commit c014e5b.

@jrbourbeau
Copy link
Member Author

@scharlottej13 updated favicon.ico over in dask/dask-sphinx-theme#73 which is included in the latest dask-sphinx-theme=3.0.1 release. Closing this PR as I can confirm the new dask-sphinx-theme release fixes this issue without any code changes to distributed

@jrbourbeau jrbourbeau closed this Jun 6, 2022
@jrbourbeau jrbourbeau deleted the new-logo-performance-report branch June 6, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants