Skip to content

WIP: Track frame lengths in pickle_dumps #3841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakirkham wants to merge 1 commit into from
Closed

WIP: Track frame lengths in pickle_dumps #3841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion distributed/protocol/serialize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@
import msgpack

from . import pickle
from ..utils import has_keyword, typename
from ..utils import has_keyword, nbytes, typename
from .compression import maybe_compress, decompress
from .utils import (
unpack_frames,
pack_frames_prelude,
frame_split_size,
merge_frames,
ensure_bytes,
msgpack_opts,
)
Expand Down Expand Up @@ -56,10 +57,13 @@ def pickle_dumps(x):
frames = [None]
buffer_callback = lambda f: frames.append(memoryview(f))
frames[0] = pickle.dumps(x, buffer_callback=buffer_callback)
header["lengths"] = [nbytes(f) for f in frames]
frames = sum(map(frame_split_size, frames), [])
return header, frames


def pickle_loads(header, frames):
frames = merge_frames(header, frames)
x, buffers = frames[0], frames[1:]
return pickle.loads(x, buffers=buffers)

Expand Down