WIP: Track frame lengths in pickle_dumps
#3841
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Would have expected this already happens here, but maybe that is not working for some reason? |
jakirkham
force-pushed
the
track_pickle_frame_sizes
branch
from
537f63b to
8b1ef43
Compare
To ensure that frames are reconstructed in the expected sizes and frames are split in a way that Dask serialization can handle, manually split and later merge frames. Also track their sizes in the header.
jakirkham
force-pushed
the
track_pickle_frame_sizes
branch
from
8b1ef43 to
70b5b81
Compare
Member
Author
|
Closing as this doesn't appear to be needed. Edit: PR ( #3639 ) should address the original issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure that frames are reconstructed in the expected sizes, include the frame lengths (in bytes) in the header.
Note: This lacks a test case at the moment. Help with that would be much appreciated.
xref: #3784
cc @gshimansky @jcrist