Skip to content

fix(dashmate): missing fallback fee on testnet with core v20 #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 3 commits into from
May 1, 2023
Merged

fix(dashmate): missing fallback fee on testnet with core v20 #963

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
308adb8
fix: v20 fails to start on testnet due to changed fallbackfee default
strophy Apr 24, 2023
d5916b5
Update packages/dashmate/templates/core/dash.conf.dot
strophy Apr 24, 2023
94f7d59
chore: apply fallbackfee on all networks except mainnet
strophy Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/dashmate/templates/core/dash.conf.dot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,12 @@ zmqpubrawtxlocksig=tcp://0.0.0.0:29998
masternodeblsprivkey={{=it.core.masternode.operator.privateKey}}
{{?}}

{{? it.network !== 'mainnet'}}
fallbackfee=0.00001
{{?}}

{{? it.network === 'testnet'}}testnet=1

@lklimek lklimek Apr 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also apply to all networks, including local & devnet (not sure about production)

@strophy strophy Apr 24, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PastaPastaPasta @thephez should this value be set on mainnet as well?

@knst knst Apr 26, 2023 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From slack to keep history.

this should also apply to all networks, including local & devnet (not sure about production)

No, these changes (backport of bitcoin/bitcoin#16524) do not affect production (mainnet); it was already 0 in the past for mainnet.

As release note says:

  • -fallbackfee was 0 (disabled) by default for the main chain, but 20000 by default for the test chains. Now it is 0 by default for all chains. Testnet and regtest users will have to add fallbackfee=20000 to their configuration if they weren't setting it and they want it to keep working like before.

For dash default value were not 20.000 but 1000. So, you need to specify in config fallbackfee=0.00001 to keep same behavior as before for testnet/regnet/etc.


[test]
{{?? it.network === 'local'}}
regtest=1
Expand Down