Skip to content

fix(dashmate): missing fallback fee on testnet with core v20 - #963

Merged
QuantumExplorer merged 3 commits into
v0.25-devfrom
fix/core-20-fallbackfee
May 1, 2023
Merged

fix(dashmate): missing fallback fee on testnet with core v20#963
QuantumExplorer merged 3 commits into
v0.25-devfrom
fix/core-20-fallbackfee

Conversation

@strophy

@strophy strophy commented Apr 24, 2023

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

Dashmate failed to start core v20 with error about missing fallbackffee on testnet

What was done?

Add fallbackffee on testnet

How Has This Been Tested?

Untested

Breaking Changes

None, this has always been the fallbackfee on testnet I think

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the title fix: missing fallback fee on testnet with core v20 fix(dashmate): missing fallback fee on testnet with core v20 Apr 24, 2023
@strophy
strophy changed the base branch from v0.24-dev to v0.25-dev April 24, 2023 08:13
@strophy strophy closed this Apr 24, 2023
@strophy
strophy force-pushed the fix/core-20-fallbackfee branch from 5fce55b to db8d94f Compare April 24, 2023 08:24
@strophy strophy reopened this Apr 24, 2023
Comment thread packages/dashmate/templates/core/dash.conf.dot Outdated
@@ -51,6 +51,7 @@ masternodeblsprivkey={{=it.core.masternode.operator.privateKey}}
{{?}}

{{? it.network === 'testnet'}}testnet=1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also apply to all networks, including local & devnet (not sure about production)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PastaPastaPasta @thephez should this value be set on mainnet as well?

@knst knst Apr 26, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From slack to keep history.

this should also apply to all networks, including local & devnet (not sure about production)

No, these changes (backport of bitcoin/bitcoin#16524) do not affect production (mainnet); it was already 0 in the past for mainnet.

As release note says:

  • -fallbackfee was 0 (disabled) by default for the main chain, but 20000 by default for the test chains. Now it is 0 by default for all chains. Testnet and regtest users will have to add fallbackfee=20000 to their configuration if they weren't setting it and they want it to keep working like before.

For dash default value were not 20.000 but 1000. So, you need to specify in config fallbackfee=0.00001 to keep same behavior as before for testnet/regnet/etc.

strophy and others added 2 commits April 24, 2023 20:28
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
@strophy

strophy commented Apr 28, 2023

Copy link
Copy Markdown
Collaborator Author

Looks like CI is failing because it depends on older v0.24-dev branch. How should I get the updated code on this branch? I tried both git merge and git rebase and both showed hundreds of conflicts, which doesn't seem possible since I only edited three lines here.

@QuantumExplorer
QuantumExplorer merged commit 387aa04 into v0.25-dev May 1, 2023
@QuantumExplorer
QuantumExplorer deleted the fix/core-20-fallbackfee branch May 1, 2023 09:20
@thephez thephez added this to the v0.25.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants