fix(dashmate): missing fallback fee on testnet with core v20 - #963
Conversation
5fce55b to
db8d94f
Compare
| @@ -51,6 +51,7 @@ masternodeblsprivkey={{=it.core.masternode.operator.privateKey}} | |||
| {{?}} | |||
|
|
|||
| {{? it.network === 'testnet'}}testnet=1 | |||
There was a problem hiding this comment.
this should also apply to all networks, including local & devnet (not sure about production)
There was a problem hiding this comment.
@PastaPastaPasta @thephez should this value be set on mainnet as well?
There was a problem hiding this comment.
From slack to keep history.
this should also apply to all networks, including local & devnet (not sure about production)
No, these changes (backport of bitcoin/bitcoin#16524) do not affect production (mainnet); it was already 0 in the past for mainnet.
As release note says:
-fallbackfeewas 0 (disabled) by default for the main chain, but 20000 by default for the test chains. Now it is 0 by default for all chains. Testnet and regtest users will have to add fallbackfee=20000 to their configuration if they weren't setting it and they want it to keep working like before.
For dash default value were not 20.000 but 1000. So, you need to specify in config fallbackfee=0.00001 to keep same behavior as before for testnet/regnet/etc.
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
|
Looks like CI is failing because it depends on older |
Issue being fixed or feature implemented
Dashmate failed to start core v20 with error about missing
fallbackffeeon testnetWhat was done?
Add
fallbackffeeon testnetHow Has This Been Tested?
Untested
Breaking Changes
None, this has always been the fallbackfee on testnet I think
Checklist:
For repository code-owners and collaborators only