Skip to content

Conversation

@shumkov
Copy link
Collaborator

@shumkov shumkov commented Oct 27, 2025

Issue being fixed or feature implemented

Sometime we change package version incorrectly (#2823) that leads to hidden problems in further releases even with green release workflow run.

What was done?

  • Add to yarn constraints additional rules:
    • dash-spv, wallet-lib and dash should have versions M+1, M+7, M+3 respectively
    • the rest of packages must have the same version

How Has This Been Tested?

Testing new constraints with new values

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v2.2.0 milestone Oct 27, 2025
@shumkov shumkov self-assigned this Oct 27, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 27, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • .yarn/constraints.pro is excluded by !**/.yarn/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch build/verify-js-package-versions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

root_workspace_version(RootVersion),
workspace_field(WorkspaceCwd, 'version', _),
workspace_ident(WorkspaceCwd, Ident),
\+ special_workspace_offset(Ident, _).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is \+ correct?

Copy link
Collaborator Author

@shumkov shumkov Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants