Skip to content

Conversation

@shumkov
Copy link
Collaborator

@shumkov shumkov commented Oct 27, 2025

Issue being fixed or feature implemented

JS Dash SDK (dash), Wallet lib (@dashevo/wallet-lib), and Dash SPV (dash-spv) packages have incorrect versions.
Intentionally different major versions were reset by previous commit.

What was done?

  • Reverted original major versions for affected JS packages.

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 27, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/package/versions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@shumkov shumkov self-assigned this Oct 27, 2025
@shumkov shumkov moved this to Todo in Platform team Oct 27, 2025
@shumkov shumkov moved this from Todo to In review / testing in Platform team Oct 27, 2025
@shumkov shumkov added this to the v2.1.x milestone Oct 27, 2025
@lklimek lklimek merged commit e758848 into master Oct 27, 2025
65 of 67 checks passed
@lklimek lklimek deleted the fix/package/versions branch October 27, 2025 12:35
@github-project-automation github-project-automation bot moved this from In review / testing to Done in Platform team Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants