feat: set firebase events for merchant details - #925
Merged
HashEngineering merged 5 commits intoMar 31, 2022
Conversation
ClaudeHangui
changed the title
ClaudeHangui
commented
Mar 28, 2022
| private val binding = ItemDetailsViewBinding.inflate(LayoutInflater.from(context), this) | ||
|
|
||
| private var onSendDashClicked: (() -> Unit)? = null | ||
| private var onSendDashClicked: ((isPayingWithDash: Boolean) -> Unit)? = null |
Contributor
Author
There was a problem hiding this comment.
We are required to track only when the Pay with Dash button is clicked
HashEngineering
approved these changes
Mar 30, 2022
Syn-McJ
approved these changes
Mar 30, 2022
Syn-McJ
left a comment
Syn-McJ
left a comment
Member
There was a problem hiding this comment.
Looks good, but methods in the viewModel can be simplified to only have one general method, instead of one for each event.
| AnalyticsConstants.ExploreDash.MERCHANT_DETAILS_PAY_WITH_DASH, | ||
| bundleOf() | ||
| ) | ||
| } |
Member
There was a problem hiding this comment.
Does it need to be a separate method for each event? Perhaps a trackEvent(name: String) method is sufficient, with the caller deciding which event name constant to provide.
Otherwise, half of the viewModel will consist of these methods.
Contributor
Author
There was a problem hiding this comment.
@Syn-McJ I set up a function to handle tracking in vm
please check it out !
- refactor tracking of events on merchants/atms on explore dash
Syn-McJ
approved these changes
Mar 30, 2022
HashEngineering
deleted the
feature-explore-dash-firebase-merchant-details
branch
July 20, 2022 23:20
bfoss765
added a commit
that referenced
this pull request
Aug 11, 2026
…oled surface dash-sdk-android 0.1.0-v41int18 -> v41int19 (platform#4329 pooled funding on rust-dashcore 8f26456b: ALL_SPENDABLE account type through Rust/FFI/JNI/Kotlin, sendToAddresses/buildSignedPayment defaults flipped; carries #931 dedup, #915, #925 add_funding, #929 contact-account funding, #918 AddressState). CoreSendAllNative migrates off the v1 split surface (#4323 deprecated setFunding$sdk_release/buildSigned$sdk_release — the split is not concurrency-safe): the drain now runs new -> addOutput -> setSelectionStrategy(ALL) -> finalizeAtomic$sdk_release (atomic select+reserve+sign under the wallet-manager lock) -> ManagedCoreWallet .broadcastTransaction(FinalizedCoreTransaction). The user-facing send-all now drains the pooled ALL_SPENDABLE set (BIP44 + BIP32 + every DashPay receival account in ONE transaction); the CoinJoin drain stays pinned to the COIN_JOIN account — de-mixing remains a separate, explicit flow. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We are required to record a set of events related to user interaction within the explore dash for merchant details
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: