[NMA-1032] (CrowdNode) Withdraw - #918
Merged
HashEngineering merged 16 commits intoMar 23, 2022
Merged
Conversation
Comment on lines
+213
to
+214
| val maxPermil = ApiCode.WithdrawAll.code | ||
| val requestPermil = min(amount.value * maxPermil / balance.value, maxPermil) |
Collaborator
There was a problem hiding this comment.
Is "mil" 1000th or 0.1%?
Member
Author
There was a problem hiding this comment.
One per mil is 1/1000 or 0.1%: https://en.wikipedia.org/wiki/Per_mille
Comment on lines
+20
to
+29
| enum class ApiCode(val code: Long, val isRequest: Boolean = false) { | ||
| PleaseAcceptTerms(2, true), | ||
| WelcomeToApi(4, true), | ||
| DepositReceived(8, true), | ||
| WithdrawalQueue(16, true), | ||
| WithdrawAll(1000, false), | ||
| SignUp(131072, false), | ||
| AcceptTerms(65536, false), | ||
| MaxCode(131072, false) | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
good to see all these constants in one place.
Comment on lines
+55
to
+57
| private fun isPowerOfTwo(number: Long): Boolean { | ||
| return number and number - 1 == 0L | ||
| } |
Collaborator
There was a problem hiding this comment.
This is a very cool formula.
Comment on lines
-68
to
+69
| <string name="send_coins_fragment_hint_dusty_send">จำนวนเงินน้อยเกินไปที่จะส่ง</string> | ||
| <string name="send_coins_fragment_hint_insufficient_money">ยอดเงินไม่เพียงพอ</string> | ||
| <string name="send_coins_error_dusty_send">จำนวนเงินน้อยเกินไปที่จะส่ง</string> | ||
| <string name="send_coins_error_insufficient_money">ยอดเงินไม่เพียงพอ</string> |
Collaborator
There was a problem hiding this comment.
Luckily the memory function of Transifex will handle this change.
Collaborator
There was a problem hiding this comment.
Though I see that these strings are actually moved to common -- which is also fine. The translation update after this will also move all other languages for these strings to common.
HashEngineering
approved these changes
Mar 23, 2022
HashEngineering
left a comment
HashEngineering
left a comment
Collaborator
There was a problem hiding this comment.
great. some comments left, but no changes are required.
bfoss765
added a commit
that referenced
this pull request
Aug 11, 2026
…oled surface dash-sdk-android 0.1.0-v41int18 -> v41int19 (platform#4329 pooled funding on rust-dashcore 8f26456b: ALL_SPENDABLE account type through Rust/FFI/JNI/Kotlin, sendToAddresses/buildSignedPayment defaults flipped; carries #931 dedup, #915, #925 add_funding, #929 contact-account funding, #918 AddressState). CoreSendAllNative migrates off the v1 split surface (#4323 deprecated setFunding$sdk_release/buildSigned$sdk_release — the split is not concurrency-safe): the drain now runs new -> addOutput -> setSelectionStrategy(ALL) -> finalizeAtomic$sdk_release (atomic select+reserve+sign under the wallet-manager lock) -> ManagedCoreWallet .broadcastTransaction(FinalizedCoreTransaction). The user-facing send-all now drains the pooled ALL_SPENDABLE set (BIP44 + BIP32 + every DashPay receival account in ONE transaction); the CoinJoin drain stays pinned to the COIN_JOIN account — de-mixing remains a separate, explicit flow. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want an ability to withdraw DASH from CrowdNode.
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: