Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment and update changelog for #1664 #1668

Merged
merged 1 commit into from
May 30, 2022
Merged

Add comment and update changelog for #1664 #1668

merged 1 commit into from
May 30, 2022

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 30, 2022


Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

@jslee02 jslee02 added this to the DART 6.13.0 milestone May 30, 2022
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #1668 (928f3dc) into main (22bbcde) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1668      +/-   ##
==========================================
- Coverage   59.10%   59.08%   -0.02%     
==========================================
  Files         499      499              
  Lines       40950    40948       -2     
==========================================
- Hits        24202    24195       -7     
- Misses      16748    16753       +5     
Impacted Files Coverage Δ
dart/collision/bullet/BulletCollisionDetector.cpp 64.28% <0.00%> (+0.31%) ⬆️
dart/collision/detail/UnorderedPairs.hpp 90.00% <0.00%> (-5.00%) ⬇️
dart/dynamics/EulerJoint.cpp 70.17% <0.00%> (-2.93%) ⬇️

@jslee02 jslee02 marked this pull request as ready for review May 30, 2022 14:23
@jslee02 jslee02 merged commit e85afb9 into main May 30, 2022
@jslee02 jslee02 deleted the use_convex branch June 7, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant