Skip to content

Commit

Permalink
Enable building examples and tutorials on Windows (#1667)
Browse files Browse the repository at this point in the history
* Enable examples on Windows

* Fix build errors on Windows + VS2022

* Enable tutorials on Windows
  • Loading branch information
jslee02 authored May 30, 2022
1 parent d28c286 commit 22bbcde
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ if(TARGET dart)

# Add example subdirectories and an "examples" target.
if(MSVC)
# add_subdirectory(examples)
add_subdirectory(examples)
else()
add_subdirectory(examples EXCLUDE_FROM_ALL)
get_property(examples GLOBAL PROPERTY DART_EXAMPLES)
Expand All @@ -356,7 +356,7 @@ if(TARGET dart)

# Add a "tutorials" target to build tutorials.
if(MSVC)
# add_subdirectory(tutorials)
add_subdirectory(tutorials)
else()
add_subdirectory(tutorials EXCLUDE_FROM_ALL)
get_property(tutorials GLOBAL PROPERTY DART_TUTORIALS)
Expand Down
4 changes: 2 additions & 2 deletions examples/atlas_simbicon/TerminalCondition.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,14 @@ bool BodyContactCondition::isSatisfied()
for (std::size_t i = 0; i < soft->getNumPointMasses(); ++i)
{
PointMass* pm = soft->getPointMass(i);
if (pm->isColliding() > 0)
if (pm->isColliding())
return true;
}
}

// TODO(JS): Need more elegant condition check method
DART_SUPPRESS_DEPRECATED_BEGIN
if (mBodyNode->isColliding() > 0)
if (mBodyNode->isColliding())
DART_SUPPRESS_DEPRECATED_END
{
// dtmsg << "BodyNode [" << mBodyNode->getName() << "] is in contact."
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,14 @@ bool BodyContactCondition::isSatisfied()
for (std::size_t i = 0; i < soft->getNumPointMasses(); ++i)
{
PointMass* pm = soft->getPointMass(i);
if (pm->isColliding() > 0)
if (pm->isColliding())
return true;
}
}

// TODO(JS): Need more elegant condition check method
DART_SUPPRESS_DEPRECATED_BEGIN
if (mBodyNode->isColliding() > 0)
if (mBodyNode->isColliding())
DART_SUPPRESS_DEPRECATED_END
{
// dtmsg << "BodyNode [" << mBodyNode->getName() << "] is in contact."
Expand Down

0 comments on commit 22bbcde

Please sign in to comment.