This repository has been archived by the owner on Jul 17, 2020. It is now read-only.
Create gd.js #234
Merged
Create gd.js #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 27, 2019 12:49
Create Gàidhlig (Scottish Gaelic) translation
|
Can anybody tell me why this has failed? |
|
You have not added tests! You will want to copy, for example, |
added 23 commits
December 31, 2019 03:20
|
Thanks for your help @ironwallaby |
ghost
approved these changes
Jan 6, 2020
lib/lang/gd.js
Outdated
| "next-wednesday": "Diciadain an ath sheachdain", | ||
| "next-thursday": "Diardaoin an ath sheachdain", | ||
| "next-friday": "Dihaoine an ath sheachdain", | ||
| "next-saturday": "Disathairne an ath sheachdain", |
There was a problem hiding this comment.
There's a double space here... should probably be a single space?
|
Sorry for the delay in getting back to you, I'm finally back in from the holidays! This looks good, I just had one minor comment. Happy to merge it in whenever you're ready! |
|
No bother. I've removed that extra space now, so happy to proceed whenever you are ready. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Gàidhlig (Scottish Gaelic) translation