Skip to content
This repository has been archived by the owner on Jul 17, 2020. It is now read-only.

2.0 #165

Merged
4 commits merged into from
Feb 7, 2018
Merged

2.0 #165

4 commits merged into from
Feb 7, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 12, 2018

This PR is a work-in-progress towards a 2.0.

Changes include:

  1. BREAKING: Rename nb to no (until such time as Nynorsk is supported, anyway). (This is in order to unify the translations with Norwegian-language alerts, which are reported as no by the Norwegian government.)
  2. BREAKING: Have each translation be an object with a translate function and a is_supported function, rather than just the translate function directly. (This is in order to make it easier to support different features in different translations, allowing us to make additions to, e.g., English, without breaking support for other translations.)
  3. Have each translation export just the template module, rather than a function. (This is intended to merely clean up boilerplate.)
  4. Revise the weekly temperature summaries (as per Make weekly temperature summaries more precise #158).
  5. General cleanup and refactoring and dead code removal.

@ghost ghost added the enhancement label Jan 12, 2018
@ghost ghost self-assigned this Jan 12, 2018
@ghost ghost requested review from jeffbyrnes, jareyes and nonrenewable-zz January 12, 2018 19:30
Copy link
Contributor

@nonrenewable-zz nonrenewable-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I like this encapsulation better but maybe because i come from the world of objects in java and it's force of habit for me at times 🙂

@jeffbyrnes
Copy link
Contributor

Also breaking: rename project to darkskyapp/translations or darkskyapp/api-translations.

@ghost ghost merged commit d006c1f into master Feb 7, 2018
@ghost ghost deleted the ironwallaby/2.0 branch February 7, 2018 21:23
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants