Skip to content
This repository has been archived by the owner on Jul 17, 2020. It is now read-only.

Make weekly temperature summaries more precise #158

Closed
ghost opened this issue Sep 25, 2017 · 5 comments
Closed

Make weekly temperature summaries more precise #158

ghost opened this issue Sep 25, 2017 · 5 comments
Labels

Comments

@ghost
Copy link

ghost commented Sep 25, 2017

A Dark Sky API customer noted that this summary is poor: "Bruine demain, avec des températures atteignant 24°C jeudi." (Translation: "Drizzle tomorrow, with temperatures bottoming out at 24°C on Thursday.")

They recommend using this instead: "Bruine demain, avec des températures maximales atteignant 24°C jeudi." (Translation: "Drizzle tomorrow, with high temperatures bottoming out at 24°C on Thursday.")

This could be fixed across the board (e.g. in all languages) to make the summaries more precise.

@ghost ghost added the question label Sep 25, 2017
@ghost ghost self-assigned this Sep 25, 2017
@TheoL
Copy link
Contributor

TheoL commented Sep 26, 2017

Are you planning to make this change in English? What about "temperatures-falling"?

@kravlost
Copy link
Contributor

My school French is now very rusty but Google translates "Bruine demain, avec des températures maximales atteignant 24°C jeudi." as "Drizzle tomorrow, with maximum temperatures up to 24 ° C on Thursday".

I would parse "bottoming out" as meaning "reaching a minimum" not "reaching a maximum". This might be a UK/USA difference, I'm not sure.

For clarity I think the English should avoid the phrase "bottoming out" if there's a risk of misinterpretation.

ghost pushed a commit that referenced this issue Jan 12, 2018
@ghost ghost mentioned this issue Jan 12, 2018
Merged
ghost pushed a commit that referenced this issue Feb 7, 2018
* Rename nb to no (until nynorsk is contributed, anyway)

* Convert to Translate class, cleanup

* Clean up tests

* Clarify weekly summaries in en, fr #158
@ghost
Copy link
Author

ghost commented Feb 7, 2018

These changes (in English and French) have been incorporated into 2.0.0. Other languages can be updated opportunistically!

@ghost ghost closed this as completed Feb 7, 2018
@TheoL
Copy link
Contributor

TheoL commented Mar 28, 2018

Are these changes non in production yet? I still get results such as "... with temperatures bottoming out ..." instead of "... with high temperatures bottoming out ..."

@ghost
Copy link
Author

ghost commented Mar 28, 2018

Not yet, no. We started rolling this update (along with a number of others) into staging yesterday; if things go well it'll land in production today or tomorrow. (If not, early next week probably :) )

Sorry for the delay on getting this live!

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants