Skip to content

Conversation

@tylerkron
Copy link
Contributor

@tylerkron tylerkron commented Oct 14, 2025

User description

Summary

This PR consolidates all open Dependabot dependency updates into a single update:

  • Microsoft.NET.Test.Sdk: 17.14.1 → 18.0.0 (Daqifi.Desktop.Bootloader.Test)
  • NCalcSync: 5.6.0 → 5.7.0 (Daqifi.Desktop)
  • System.IO.Ports: 9.0.8 → 9.0.9 (Daqifi.Desktop)
  • Newtonsoft.Json: 13.0.3 → 13.0.4 (Daqifi.Desktop, Daqifi.Desktop.Bootloader)

Test plan

  • All dependency updates applied successfully
  • No breaking changes detected
  • Package version conflicts resolved (Newtonsoft.Json updated across all projects)
  • Build and tests pass on Windows CI

Related PRs

Closes #283, #282, #281, #280

🤖 Generated with Claude Code


PR Type

Other


Description

  • Update four NuGet package dependencies to latest versions

  • Bump Microsoft.NET.Test.Sdk from 17.14.1 to 18.0.0

  • Bump NCalcSync from 5.6.0 to 5.7.0

  • Bump System.IO.Ports from 9.0.8 to 9.0.9

  • Bump Newtonsoft.Json from 13.0.3 to 13.0.4 across projects


Diagram Walkthrough

flowchart LR
  A["Dependency Updates"] --> B["Test SDK 18.0.0"]
  A --> C["NCalcSync 5.7.0"]
  A --> D["System.IO.Ports 9.0.9"]
  A --> E["Newtonsoft.Json 13.0.4"]
  B --> F["Bootloader.Test"]
  C --> G["Desktop"]
  D --> G
  E --> G
  E --> H["Bootloader"]
Loading

File Walkthrough

Relevant files
Dependencies
Daqifi.Desktop.Bootloader.Test.csproj
Upgrade test SDK to version 18.0.0                                             

Daqifi.Desktop.Bootloader.Test/Daqifi.Desktop.Bootloader.Test.csproj

  • Updated Microsoft.NET.Test.Sdk package from version 17.14.1 to 18.0.0
+1/-1     
Daqifi.Desktop.Bootloader.csproj
Bump Newtonsoft.Json to 13.0.4                                                     

Daqifi.Desktop.Bootloader/Daqifi.Desktop.Bootloader.csproj

  • Updated Newtonsoft.Json package from version 13.0.3 to 13.0.4
+1/-1     
Daqifi.Desktop.csproj
Update three package dependencies to latest versions         

Daqifi.Desktop/Daqifi.Desktop.csproj

  • Updated NCalcSync package from version 5.6.0 to 5.7.0
  • Updated Newtonsoft.Json package from version 13.0.3 to 13.0.4
  • Updated System.IO.Ports package from version 9.0.8 to 9.0.9
+108/-108

This PR consolidates the following Dependabot updates:
- Bump Microsoft.NET.Test.Sdk from 17.14.1 to 18.0.0
- Bump NCalcSync from 5.6.0 to 5.7.0
- Bump System.IO.Ports from 9.0.8 to 9.0.9
- Bump Newtonsoft.Json from 13.0.3 to 13.0.4

All dependency updates have been tested and are compatible.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@tylerkron tylerkron requested a review from a team as a code owner October 14, 2025 03:14
@qodo-merge-pro
Copy link
Contributor

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-merge-pro
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@github-actions
Copy link

📊 Code Coverage Report

Summary

Summary
Generated on: 10/14/2025 - 3:16:27 AM
Coverage date: 10/14/2025 - 3:16:13 AM - 10/14/2025 - 3:16:24 AM
Parser: MultiReport (5x Cobertura)
Assemblies: 5
Classes: 120
Files: 154
Line coverage: 11.7% (673 of 5726)
Covered lines: 673
Uncovered lines: 5053
Coverable lines: 5726
Total lines: 17569
Branch coverage: 11.6% (239 of 2043)
Covered branches: 239
Total branches: 2043
Method coverage: Feature is only available for sponsors

Coverage

DAQiFi - 10.2%
Name Line Branch
DAQiFi 10.2% 10.7%
Daqifi.Desktop.App 3% 0%
Daqifi.Desktop.Channel.AbstractChannel 28.5% 30%
Daqifi.Desktop.Channel.AnalogChannel 88.4%
Daqifi.Desktop.Channel.Channel 11.5% 0%
Daqifi.Desktop.Channel.ChannelColorManager 100% 100%
Daqifi.Desktop.Channel.DataSample 90.4%
Daqifi.Desktop.Channel.DigitalChannel 0%
Daqifi.Desktop.Commands.CompositeCommand 0% 0%
Daqifi.Desktop.Commands.HostCommands 0%
Daqifi.Desktop.Commands.WeakEventHandlerManager 0% 0%
Daqifi.Desktop.Configuration.FirewallConfiguration 90.6% 66.6%
Daqifi.Desktop.Configuration.WindowsFirewallWrapper 64% 68.4%
Daqifi.Desktop.ConnectionManager 40.9% 55.8%
Daqifi.Desktop.Converters.BoolToActiveStatusConverter 0% 0%
Daqifi.Desktop.Converters.BoolToConnectionStatusConverter 0% 0%
Daqifi.Desktop.Converters.BoolToStatusColorConverter 0% 0%
Daqifi.Desktop.Converters.ConnectionTypeToColorConverter 0% 0%
Daqifi.Desktop.Converters.ConnectionTypeToUsbConverter 0% 0%
Daqifi.Desktop.Converters.InvertedBoolToVisibilityConverter 0% 0%
Daqifi.Desktop.Converters.ListToStringConverter 0% 0%
Daqifi.Desktop.Converters.NotNullToVisibilityConverter 0% 0%
Daqifi.Desktop.Converters.OxyColorToBrushConverter 0% 0%
Daqifi.Desktop.Device.AbstractStreamingDevice 5.4% 2.9%
Daqifi.Desktop.Device.DeviceMessage 0%
Daqifi.Desktop.Device.HidDevice.HidDeviceFinder 0% 0%
Daqifi.Desktop.Device.HidDevice.HidFirmwareDevice 0%
Daqifi.Desktop.Device.NativeMethods 0%
Daqifi.Desktop.Device.SerialDevice.SerialDeviceFinder 0% 0%
Daqifi.Desktop.Device.SerialDevice.SerialDeviceHelper 0% 0%
Daqifi.Desktop.Device.SerialDevice.SerialStreamingDevice 7.7% 15%
Daqifi.Desktop.Device.SerialDevice.UsbDevice 0% 0%
Daqifi.Desktop.Device.WiFiDevice.DaqifiDeviceFinder 0% 0%
Daqifi.Desktop.Device.WiFiDevice.DaqifiStreamingDevice 19.6% 0%
Daqifi.Desktop.DialogService.DialogService 0% 0%
Daqifi.Desktop.DialogService.ServiceLocator 0% 0%
Daqifi.Desktop.DuplicateDeviceCheckResult 100%
Daqifi.Desktop.Exporter.OptimizedLoggingSessionExporter 29.7% 32.9%
Daqifi.Desktop.Exporter.SampleData 0%
Daqifi.Desktop.Helpers.BooleanConverter`1 0% 0%
Daqifi.Desktop.Helpers.BooleanToInverseBoolConverter 0% 0%
Daqifi.Desktop.Helpers.BooleanToVisibilityConverter 0%
Daqifi.Desktop.Helpers.EnumDescriptionConverter 100% 100%
Daqifi.Desktop.Helpers.IntToVisibilityConverter 0% 0%
Daqifi.Desktop.Helpers.MyMultiValueConverter 0%
Daqifi.Desktop.Helpers.NaturalSortHelper 100% 100%
Daqifi.Desktop.Helpers.VersionHelper 98.2% 66.2%
Daqifi.Desktop.Logger.DatabaseLogger 0% 0%
Daqifi.Desktop.Logger.LoggedSeriesLegendItem 0% 0%
Daqifi.Desktop.Logger.LoggingContext 0%
Daqifi.Desktop.Logger.LoggingManager 0% 0%
Daqifi.Desktop.Logger.LoggingSession 26.6% 0%
Daqifi.Desktop.Logger.PlotLogger 0% 0%
Daqifi.Desktop.Logger.SummaryLogger 0% 0%
Daqifi.Desktop.Loggers.FirmwareUpdatationManager 5.8% 0%
Daqifi.Desktop.MainWindow 0% 0%
Daqifi.Desktop.Migrations.InitialSQLiteMigration 0%
Daqifi.Desktop.Migrations.LoggingContextModelSnapshot 0%
Daqifi.Desktop.Models.AddProfileModel 0%
Daqifi.Desktop.Models.DaqifiSettings 86.3% 100%
Daqifi.Desktop.Models.DebugDataCollection 0% 0%
Daqifi.Desktop.Models.DebugDataModel 0% 0%
Daqifi.Desktop.Models.Notifications 0%
Daqifi.Desktop.Models.SdCardFile 0%
Daqifi.Desktop.Services.WindowsPrincipalAdminChecker 0%
Daqifi.Desktop.Services.WpfMessageBoxService 0%
Daqifi.Desktop.UpdateVersion.VersionNotification 0% 0%
Daqifi.Desktop.View.AddChannelDialog 0% 0%
Daqifi.Desktop.View.AddProfileConfirmationDialog 0% 0%
Daqifi.Desktop.View.AddprofileDialog 0% 0%
Daqifi.Desktop.View.ConnectionDialog 0% 0%
Daqifi.Desktop.View.DebugWindow 0% 0%
Daqifi.Desktop.View.DeviceLogsView 0% 0%
Daqifi.Desktop.View.DuplicateDeviceDialog 0% 0%
Daqifi.Desktop.View.ErrorDialog 0% 0%
Daqifi.Desktop.View.ExportDialog 0% 0%
Daqifi.Desktop.View.FirmwareDialog 0% 0%
Daqifi.Desktop.View.Flyouts.ChannelsFlyout 0% 0%
Daqifi.Desktop.View.Flyouts.DevicesFlyout 0% 0%
Daqifi.Desktop.View.Flyouts.FirmwareFlyout 0% 0%
Daqifi.Desktop.View.Flyouts.LiveGraphFlyout 0% 0%
Daqifi.Desktop.View.Flyouts.LoggedSessionFlyout 0% 0%
Daqifi.Desktop.View.Flyouts.NotificationsFlyout 0% 0%
Daqifi.Desktop.View.Flyouts.SummaryFlyout 0% 0%
Daqifi.Desktop.View.Flyouts.UpdateProfileFlyout 0% 0%
Daqifi.Desktop.View.SelectColorDialog 0% 0%
Daqifi.Desktop.View.SettingsDialog 0% 0%
Daqifi.Desktop.View.SuccessDialog 0% 0%
Daqifi.Desktop.ViewModels.AddChannelDialogViewModel 0% 0%
Daqifi.Desktop.ViewModels.AddProfileConfirmationDialogViewModel 0% 0%
Daqifi.Desktop.ViewModels.AddProfileDialogViewModel 0% 0%
Daqifi.Desktop.ViewModels.ConnectionDialogViewModel 0% 0%
Daqifi.Desktop.ViewModels.DaqifiViewModel 0% 0%
Daqifi.Desktop.ViewModels.DeviceLogsViewModel 0% 0%
Daqifi.Desktop.ViewModels.DeviceSettingsViewModel 0% 0%
Daqifi.Desktop.ViewModels.DuplicateDeviceDialogViewModel 0%
Daqifi.Desktop.ViewModels.ErrorDialogViewModel 0%
Daqifi.Desktop.ViewModels.ExportDialogViewModel 0% 0%
Daqifi.Desktop.ViewModels.FirmwareDialogViewModel 0% 0%
Daqifi.Desktop.ViewModels.SelectColorDialogViewModel 0% 0%
Daqifi.Desktop.ViewModels.SettingsViewModel 0%
Daqifi.Desktop.ViewModels.SuccessDialogViewModel 0%
Daqifi.Desktop.WindowViewModelMapping.IWindowViewModelMappingsContract 0%
Daqifi.Desktop.WindowViewModelMapping.WindowViewModelMappings 0%
Daqifi.Desktop.Bootloader - 20.6%
Name Line Branch
Daqifi.Desktop.Bootloader 20.6% 17.3%
Daqifi.Desktop.Bootloader.Crc16 100% 100%
Daqifi.Desktop.Bootloader.Exceptions.FirmwareUpdateException 0%
Daqifi.Desktop.Bootloader.FirmwareDownloader 82% 66.6%
Daqifi.Desktop.Bootloader.Pic32Bootloader 0% 0%
Daqifi.Desktop.Bootloader.Pic32BootloaderMessageConsumer 0% 0%
Daqifi.Desktop.Bootloader.Pic32BootloaderMessageProducer 80.9% 100%
Daqifi.Desktop.Bootloader.WifiFirmwareDownloader 0% 0%
Daqifi.Desktop.Bootloader.WifiModuleUpdater 0% 0%
Daqifi.Desktop.Common - 45.9%
Name Line Branch
Daqifi.Desktop.Common 45.9% 33.3%
Daqifi.Desktop.Common.Loggers.AppLogger 42.1% 33.3%
Daqifi.Desktop.Common.Loggers.NoOpLogger 100%
Daqifi.Desktop.DataModel - 100%
Name Line Branch
Daqifi.Desktop.DataModel 100% ****
Daqifi.Desktop.DataModel.Device.DeviceInfo 100%
Daqifi.Desktop.IO - 23.9%
Name Line Branch
Daqifi.Desktop.IO 23.9% 18.9%
Daqifi.Desktop.IO.Messages.Consumers.AbstractMessageConsumer 0% 0%
Daqifi.Desktop.IO.Messages.Consumers.MessageConsumer 0% 0%
Daqifi.Desktop.IO.Messages.Consumers.TextMessageConsumer 0% 0%
Daqifi.Desktop.IO.Messages.Decoders.ProtobufDecoder 100% 75%
Daqifi.Desktop.IO.Messages.MessageEventArgs`1 0%
Daqifi.Desktop.IO.Messages.Producers.MessageProducer 81% 80%

Coverage report generated by ReportGeneratorView full report in build artifacts

@tylerkron tylerkron merged commit c77ab62 into main Oct 14, 2025
3 checks passed
@tylerkron tylerkron deleted the deps/consolidate-dependabot-updates branch October 14, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants