Skip to content

deps: Bump Newtonsoft.Json from 13.0.3 to 13.0.4 #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

deps: Bump Newtonsoft.Json from 13.0.3 to 13.0.4 #280

wants to merge 2 commits into from

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 22, 2025 •
edited
Loading

Updated Newtonsoft.Json from 13.0.3 to 13.0.4.

Release notes

Sourced from Newtonsoft.Json's releases.

13.0.4

  • New feature - Annotated for trim/AOT (in)compatibility
  • New feature - Added support for using Index with JArray
  • Change - Avoid LINQ expression trees in .NET 6+ reflection
  • Fix - Fixed handling of empty constructor names
  • Fix - Fixed XML convert duplicate attribute error on nested arrays with writeArrayAttribute set to true
  • Fix - Fixed XML convert array attribute is not set for properties with special characters
  • Fix - Fixed TimeOnly deserialization to support more formats

Commits viewable in compare view.

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot
deps: Bump Newtonsoft.Json from 13.0.3 to 13.0.4
590bed6 
---
updated-dependencies:
- dependency-name: Newtonsoft.Json
  dependency-version: 13.0.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner September 22, 2025 06:33
@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Oct 14, 2025

CI Feedback 🧐

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: build-and-test

Failed stage: Restore dependencies [❌]

Failure summary:

The action failed during "dotnet restore" due to NuGet error NU1605 (Warning As Error) caused by a
package version downgrade conflict for Newtonsoft.Json:
- Daqifi.Desktop.Bootloader requires
Newtonsoft.Json (>= 13.0.4).
- The projects Daqifi.Desktop.Test and Daqifi.Desktop resolve
Newtonsoft.Json (>= 13.0.3), resulting in a downgrade from 13.0.4 to 13.0.3.
- Affected files:
-
D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop.Test\Daqifi.Desktop.Test.csproj (lines 134–137)

- D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop\Daqifi.Desktop.csproj (lines 138–141)
- Because
warnings are treated as errors, restore failed and the job exited with code 1.

Relevant error logs: 
1:  ##[group]Runner Image Provisioner
2:  Hosted Compute Agent
...

119:  ##[group]Run dotnet restore
120:  �[36;1mdotnet restore�[0m
121:  shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
122:  env:
123:  DOTNET_ROOT: C:\Program Files\dotnet
124:  ##[endgroup]
125:  Determining projects to restore...
126:  Restored D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop.Common.Test\Daqifi.Desktop.Common.Test.csproj (in 22.54 sec).
127:  Restored D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop.DataModel.Test\Daqifi.Desktop.DataModel.Test.csproj (in 22.54 sec).
128:  Restored D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop.IO\Daqifi.Desktop.IO.csproj (in 10.06 sec).
129:  Restored D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop.IO.Test\Daqifi.Desktop.IO.Test.csproj (in 10.06 sec).
130:  Restored D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop.DataModel\Daqifi.Desktop.DataModel.csproj (in 2 ms).
131:  Restored D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop.Common\Daqifi.Desktop.Common.csproj (in 2 ms).
132:  Restored D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop.Bootloader.Test\Daqifi.Desktop.Bootloader.Test.csproj (in 1.84 sec).
133:  Restored D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop.Bootloader\Daqifi.Desktop.Bootloader.csproj (in 1.82 sec).
134:  D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop.Test\Daqifi.Desktop.Test.csproj : error NU1605: Warning As Error: Detected package downgrade: Newtonsoft.Json from 13.0.4 to 13.0.3. Reference the package directly from the project to select a different version.  [D:\a\daqifi-desktop\daqifi-desktop\DAQIifi Desktop.sln]
135:  D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop.Test\Daqifi.Desktop.Test.csproj : error NU1605:  Daqifi.Desktop.Test -> DAQiFi -> Daqifi.Desktop.Bootloader -> Newtonsoft.Json (>= 13.0.4)  [D:\a\daqifi-desktop\daqifi-desktop\DAQIifi Desktop.sln]
136:  D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop.Test\Daqifi.Desktop.Test.csproj : error NU1605:  Daqifi.Desktop.Test -> DAQiFi -> Newtonsoft.Json (>= 13.0.3) [D:\a\daqifi-desktop\daqifi-desktop\DAQIifi Desktop.sln]
137:  Failed to restore D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop.Test\Daqifi.Desktop.Test.csproj (in 48.11 sec).
138:  D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop\Daqifi.Desktop.csproj : error NU1605: Warning As Error: Detected package downgrade: Newtonsoft.Json from 13.0.4 to 13.0.3. Reference the package directly from the project to select a different version.  [D:\a\daqifi-desktop\daqifi-desktop\DAQIifi Desktop.sln]
139:  D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop\Daqifi.Desktop.csproj : error NU1605:  DAQiFi -> Daqifi.Desktop.Bootloader -> Newtonsoft.Json (>= 13.0.4)  [D:\a\daqifi-desktop\daqifi-desktop\DAQIifi Desktop.sln]
140:  D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop\Daqifi.Desktop.csproj : error NU1605:  DAQiFi -> Newtonsoft.Json (>= 13.0.3) [D:\a\daqifi-desktop\daqifi-desktop\DAQIifi Desktop.sln]
141:  Failed to restore D:\a\daqifi-desktop\daqifi-desktop\Daqifi.Desktop\Daqifi.Desktop.csproj (in 50.53 sec).
142:  ##[error]Process completed with exit code 1.
143:  Post job cleanup.

@tylerkron tylerkron mentioned this pull request Oct 14, 2025
Merged
4 tasks
tylerkron added a commit that referenced this pull request Oct 28, 2025
@tylerkron @claude
deps: Combine dependency updates from Dependabot PRs
a0832ee 
This commit combines the following Dependabot PRs:
- PR #295: Bump Microsoft.Data.Sqlite from 9.0.9 to 9.0.10
- PR #294: Bump actions/upload-artifact from 4 to 5
- PR #288: Bump EFCore.BulkExtensions from 9.0.1 to 9.0.2
- PR #281: Bump System.IO.Ports from 9.0.8 to 9.0.9
- PR #280: Bump Newtonsoft.Json from 13.0.3 to 13.0.4 (already applied)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@tylerkron tylerkron mentioned this pull request Oct 28, 2025
Merged
3 tasks
@tylerkron
Copy link
Contributor

tylerkron commented Oct 28, 2025

Closed in favor of combined PR #296

@tylerkron tylerkron closed this Oct 28, 2025
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 28, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/nuget/Daqifi.Desktop.Bootloader/Newtonsoft.Json-13.0.4 branch October 28, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies nuget

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tylerkron