Skip to content

Changed distributedLock example to consider a new default port number #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
halspang merged 3 commits into from
Oct 24, 2022
Merged

Changed distributedLock example to consider a new default port number #966

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38cfef9
Changed distributedLock example to consider a new default port number
amulyavarote Oct 4, 2022
f5d4441
Changes based on the review comments
amulyavarote Oct 6, 2022
9d749ef
Merge branch 'master' into lockexample_changes
halspang Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/Client/DistributedLock/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public static IHostBuilder CreateHostBuilder(string[] args) =>
.ConfigureWebHostDefaults(webBuilder =>
{
webBuilder.UseStartup<Startup>()
.UseUrls($"http://localhost:{Environment.GetEnvironmentVariable("APP_PORT")}");
.UseUrls($"http://localhost:{Environment.GetEnvironmentVariable("APP_PORT") ?? "22222"}");

@yash-nisar yash-nisar Oct 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Instead of directly hardcoding the number, do you want to define this in a variable like DEFAULT_APP_PORT for better readability ?

@amulyavarote amulyavarote Oct 6, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! Makes sense!

});
}
}