Changed distributedLock example to consider a new default port number#966
Merged
Conversation
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## master #966 +/- ##
=======================================
Coverage 69.78% 69.78%
=======================================
Files 156 156
Lines 5186 5186
Branches 555 555
=======================================
Hits 3619 3619
Misses 1435 1435
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
yash-nisar
reviewed
Oct 6, 2022
| { | ||
| webBuilder.UseStartup<Startup>() | ||
| .UseUrls($"http://localhost:{Environment.GetEnvironmentVariable("APP_PORT")}"); | ||
| .UseUrls($"http://localhost:{Environment.GetEnvironmentVariable("APP_PORT") ?? "22222"}"); |
Contributor
There was a problem hiding this comment.
nit: Instead of directly hardcoding the number, do you want to define this in a variable like DEFAULT_APP_PORT for better readability ?
Contributor
Author
There was a problem hiding this comment.
Yup! Makes sense!
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
halspang
approved these changes
Oct 24, 2022
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amulya Varote amulyavarote@microsoft.com
Description
Please explain the changes you've made
Changed distributedLock example to consider a new default port number to avoid default port conflict.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #NA
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: