Skip to content

Workflow generator supports abstract classes - #1902

Merged
WhitWaldo merged 1 commit into
masterfrom
workflow-abstract
Aug 26, 2026
Merged

WhitWaldo merged 1 commit into
masterfrom
workflow-abstract

Conversation

@WhitWaldo

Copy link
Copy Markdown
Contributor

Description

Fixing reported issue with abstract workflows not properly generating. Proactively went and added other tests to validate correctness:

  • Abstract open (C# 15 feature) classes
  • Concrete open (again, C# 15 feature) classes
  • Abstract generic base class
  • Abstract open generic class
  • Concrete open generic class
  • Concrete closed (workflow versioning)
  • Non-workflow class (validate no workflows registered) - false-positive guard

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1898

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

…. Proactively went and added other tests to validate correctness:

- Abstract open (C# 15 feature) classes
- Concrete open (again, C# 15 feature) classes
- Abstract generic base class
- Abstract open generic class
- Concrete open generic class
 - Concrete closed (workflow versioning)
 - Non-workflow class (validate no workflows registered) - false-positive guard

 Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@WhitWaldo WhitWaldo added this to the v1.18.x - SDK Patches milestone Aug 26, 2026
@WhitWaldo WhitWaldo self-assigned this Aug 26, 2026
@WhitWaldo
WhitWaldo requested review from a team as code owners August 26, 2026 02:51
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.61%. Comparing base (1c24788) to head (9b4e4b2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1902      +/-   ##
==========================================
- Coverage   62.62%   62.61%   -0.02%     
==========================================
  Files         338      338              
  Lines        9972     9972              
  Branches     1174     1174              
==========================================
- Hits         6245     6244       -1     
  Misses       3403     3403              
- Partials      324      325       +1     
Flag Coverage Δ
net10.0 62.57% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dapr.Workflow 1.18] Code generation for registration of workflows does not distinguish between abstract and concrete classes.

1 participant