Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ForcePathStyle support for s3 binding #2054

Merged
merged 3 commits into from
Dec 24, 2021
Merged

add ForcePathStyle support for s3 binding #2054

merged 3 commits into from
Dec 24, 2021

Conversation

rainfd
Copy link
Contributor

@rainfd rainfd commented Dec 19, 2021

Signed-off-by: rainfd [email protected]

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Add S3ForcePathStyle field for s3 binding.

Issue reference

#2022
dapr/components-contrib#1360

@yaron2 yaron2 added this to the 1.6 milestone Dec 24, 2021
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 90fb822 into dapr:v1.5 Dec 24, 2021
msfussell added a commit that referenced this pull request Dec 28, 2021
* Added pub sub documentation

* Changed port number in the command

* Modified based on the review comments - 1

* Modified based on the review comments - 2

* Changed python commands

* Changed python commands

* Modified based on the review comments - 3

* Fix publish a topic examples

Step 3 and 4 of the "How-To: Publish & subscribe" publishes to the
wrong app id and pubsub. This commit fixes by changing the examples
that write to the app-id "testpubsub" to "orderprocessing"
and the pubsub "pubsub" to "order_pub_sub"

* Wrap oauth links in ignore comment

* Bumping tags to v1.5.0

* Update dapr versions for 1.5.1 hotfix

* Correct the default component init timeout

Signed-off-by: Amulya Varote <[email protected]>

* Fix incorrect warning log-level

Signed-off-by: Amulya Varote <[email protected]>

* Added bindings documentation

Signed-off-by: Amulya Varote <[email protected]>

* Changed python commands

Signed-off-by: Amulya Varote <[email protected]>

* Changed image for bindings

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments - 2

Signed-off-by: Amulya Varote <[email protected]>

* Reverted a small change

Signed-off-by: Amulya Varote <[email protected]>

* Added pub sub documentation

Signed-off-by: Amulya Varote <[email protected]>

* Changed port number in the command

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments - 2

Signed-off-by: Amulya Varote <[email protected]>

* Changed python commands

Signed-off-by: Amulya Varote <[email protected]>

* Changed python commands

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments - 3

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments - 2

Signed-off-by: Amulya Varote <[email protected]>

* Wrap oauth links in ignore comment

Signed-off-by: Amulya Varote <[email protected]>

* Bumping tags to v1.5.0

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments -3

Signed-off-by: Amulya Varote <[email protected]>

* Modified a line based on the review comment

Signed-off-by: Amulya Varote <[email protected]>

* Fix publish a topic examples

Step 3 and 4 of the "How-To: Publish & subscribe" publishes to the
wrong app id and pubsub. This commit fixes by changing the examples
that write to the app-id "testpubsub" to "orderprocessing"
and the pubsub "pubsub" to "order_pub_sub"

Signed-off-by: Amulya Varote <[email protected]>

* Update dapr versions for 1.5.1 hotfix

Signed-off-by: Amulya Varote <[email protected]>

* Modified a line based on the review comment

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments

Signed-off-by: Amulya Varote <[email protected]>

* Added pub sub documentation

Signed-off-by: Amulya Varote <[email protected]>

* Changed port number in the command

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <[email protected]>

* Added secrets store documentation

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments - 2

Signed-off-by: Amulya Varote <[email protected]>

* Update daprdocs/content/en/developing-applications/building-blocks/secrets/howto-secrets.md

Signed-off-by: Amulya Varote <[email protected]>

* Update daprdocs/content/en/developing-applications/building-blocks/secrets/howto-secrets.md

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments - 2

Signed-off-by: Amulya Varote <[email protected]>

* Changed python commands

Signed-off-by: Amulya Varote <[email protected]>

* Changed python commands

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments - 3

Signed-off-by: Amulya Varote <[email protected]>

* Fix publish a topic examples

Step 3 and 4 of the "How-To: Publish & subscribe" publishes to the
wrong app id and pubsub. This commit fixes by changing the examples
that write to the app-id "testpubsub" to "orderprocessing"
and the pubsub "pubsub" to "order_pub_sub"

Signed-off-by: Amulya Varote <[email protected]>

* Added full code snippets for service invocation

Signed-off-by: Amulya Varote <[email protected]>

* Added full code snippets of secrets management

Signed-off-by: Amulya Varote <[email protected]>

* Added full code snippets of state management

Signed-off-by: Amulya Varote <[email protected]>

* Added full code snippets of pub sub

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <[email protected]>

* Removed a line

Signed-off-by: Amulya Varote <[email protected]>

* resolved merge conflicts

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <[email protected]>

* Added full code snippets of secrets management

Signed-off-by: Amulya Varote <[email protected]>

* Added full code snippets of pub sub

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <[email protected]>

* Removed a line

Signed-off-by: Amulya Varote <[email protected]>

* Added full code snippets of secrets management

Signed-off-by: Amulya Varote <[email protected]>

* Added full code snippets of pub sub

Signed-off-by: Amulya Varote <[email protected]>

* Modified based on the review comments - 1

Signed-off-by: Amulya Varote <[email protected]>

* Solved merge conflicts

Signed-off-by: Amulya Varote <[email protected]>

* Modified go secrets code

Signed-off-by: Amulya Varote <[email protected]>

* Update daprdocs/content/en/developing-applications/building-blocks/secrets/howto-secrets.md

Co-authored-by: Will <[email protected]>

* Added DCO sign-off guidance for contributing to Dapr

Signed-off-by: Nick Greenfield <[email protected]>

* Address PR feedback

Signed-off-by: Nick Greenfield <[email protected]>

* Add DCO check to PR template

Signed-off-by: Nick Greenfield <[email protected]>

* simplify git command for DCO

Signed-off-by: Will Tsai <[email protected]>

* Fix header

* Display state value instead of StateResponse object (#2046)

Signed-off-by: Jun Tian <[email protected]>

Co-authored-by: greenie-msft <[email protected]>

* add ForcePathStyle support for s3 binding (#2054)

Signed-off-by: rainfd <[email protected]>

Co-authored-by: greenie-msft <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>

* Remove requests dep (#2055)

* Add DCO check to PR template

Signed-off-by: Nick Greenfield <[email protected]>

* Remove requests dep

Signed-off-by: GitHub <[email protected]>

Co-authored-by: Nick Greenfield <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>

* update endpoint in s3 binding doc (#2049)

* update endpoint in s3 binding doc

Signed-off-by: lizzzcai <[email protected]>

* fix jaeger link

Signed-off-by: lizzzcai <[email protected]>

* update endpoint example to match region

Signed-off-by: lizzzcai <[email protected]>

Co-authored-by: Mark Fussell <[email protected]>

* Update autoscale-keda.md (#2047)

Co-authored-by: greenie-msft <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>

* Update service-mesh.md (#2044)

Minor typo

Co-authored-by: greenie-msft <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>

* Added missing HTTP verb to the documentation dapr/dapr#4030 (#2045)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: Mark Fussell <[email protected]>

* Update logs-troubleshooting.md (#2023)

The label name `dapr-placement` has been changed to `dapr-placement-server`.

Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>

* update the DOTNET SDK

Signed-off-by: Mark Fussell <[email protected]>

Co-authored-by: Amulya Varote <[email protected]>
Co-authored-by: Amulya Varote <[email protected]>
Co-authored-by: Amulya Varote <[email protected]>
Co-authored-by: David Millman <[email protected]>
Co-authored-by: emctl <[email protected]>
Co-authored-by: Bernd Verst <[email protected]>
Co-authored-by: Will <[email protected]>
Co-authored-by: Will Tsai <[email protected]>
Co-authored-by: Aaron Crawfis <[email protected]>
Co-authored-by: Jun Tian <[email protected]>
Co-authored-by: RainFD <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
Co-authored-by: ChethanUK <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Lize <[email protected]>
Co-authored-by: Andrew Cartwright <[email protected]>
Co-authored-by: Shriroop Joshi <[email protected]>
Co-authored-by: Christoph Hofmann <[email protected]>
Co-authored-by: Will 保哥 <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
robsondepaula pushed a commit to sidilabs/docs that referenced this pull request Dec 30, 2021
Signed-off-by: rainfd <[email protected]>

Co-authored-by: greenie-msft <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Antonio Robson de Paula <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants