You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/pull_request_template.md
+1-1
Original file line number
Diff line number
Diff line change
@@ -1,7 +1,7 @@
1
1
Thank you for helping make the Dapr documentation better!
2
2
3
3
**Please follow this checklist before submitting:**
4
-
4
+
-[ ] Commits are signed with Developer Certificate of Origin (DCO - [learn more](https://docs.dapr.io/contributing/contributing-overview/#developer-certificate-of-origin-signing-your-work))
5
5
-[ ][Read the contribution guide](https://docs.dapr.io/contributing/contributing-docs/)
6
6
-[ ] Commands include options for Linux, MacOS, and Windows within codetabs
7
7
-[ ] New file and folder names are globally unique
Copy file name to clipboardExpand all lines: daprdocs/content/en/concepts/service-mesh.md
+1-1
Original file line number
Diff line number
Diff line change
@@ -7,7 +7,7 @@ description: >
7
7
How Dapr compares to and works with service meshes
8
8
---
9
9
10
-
Dapr uses a sidecar architecture, running as a separate process alongside the application and includes features such as service invocation, network security, and distributed tracing. This often raises the question: how does Dapr compare to service mesh solutions such as [Linkerd](https://linkerd.io/), [Istio](https://istio.io/) and [Open Service Mesh](https://openservicemesh.io/)amoung others?
10
+
Dapr uses a sidecar architecture, running as a separate process alongside the application and includes features such as service invocation, network security, and distributed tracing. This often raises the question: how does Dapr compare to service mesh solutions such as [Linkerd](https://linkerd.io/), [Istio](https://istio.io/) and [Open Service Mesh](https://openservicemesh.io/)among others?
11
11
12
12
## How Dapr and service meshes compare
13
13
While Dapr and service meshes do offer some overlapping capabilities, **Dapr is not a service mesh**, where a service mesh is defined as a *networking* service mesh. Unlike a service mesh which is focused on networking concerns, Dapr is focused on providing building blocks that make it easier for developers to build applications as microservices. Dapr is developer-centric, versus service meshes which are infrastructure-centric.
Copy file name to clipboardExpand all lines: daprdocs/content/en/contributing/contributing-overview.md
+38-2
Original file line number
Diff line number
Diff line change
@@ -43,6 +43,7 @@ Before you submit an issue, make sure you've checked the following:
43
43
- Many changes to the Dapr runtime may require changes to the API. In that case, the best place to discuss the potential feature is the main [Dapr repo](https://github.com/dapr/dapr).
44
44
- Other examples could include bindings, state stores or entirely new components.
45
45
46
+
46
47
## Pull Requests
47
48
48
49
All contributions come through pull requests. To submit a proposed change, follow this workflow:
@@ -53,18 +54,53 @@ All contributions come through pull requests. To submit a proposed change, follo
53
54
1. Create your change
54
55
- Code changes require tests
55
56
1. Update relevant documentation for the change
56
-
1. Commit and open a PR
57
+
1. Commit with [DCO sign-off]({{< ref "contributing-overview.md#developer-certificate-of-origin-signing-your-work" >}}) and open a PR
57
58
1. Wait for the CI process to finish and make sure all checks are green
58
59
1. A maintainer of the project will be assigned, and you can expect a review within a few days
59
60
61
+
60
62
#### Use work-in-progress PRs for early feedback
61
63
62
64
A good way to communicate before investing too much time is to create a "Work-in-progress" PR and share it with your reviewers. The standard way of doing this is to add a "[WIP]" prefix in your PR's title and assign the **do-not-merge** label. This will let people looking at your PR know that it is not well baked yet.
63
65
64
-
###Use of Third-party code
66
+
## Use of Third-party code
65
67
66
68
- Third-party code must include licenses.
67
69
70
+
## Developer Certificate of Origin: Signing your work
71
+
#### Every commit needs to be signed
72
+
73
+
The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the [DCO](https://developercertificate.org/), reformatted for readability:
74
+
```
75
+
By making a contribution to this project, I certify that:
76
+
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
77
+
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
78
+
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
79
+
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.
80
+
```
81
+
Contributors sign-off that they adhere to these requirements by adding a `Signed-off-by` line to commit messages.
0 commit comments