Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support KiND cluster for local dev environment #800 #2038

Merged
merged 21 commits into from
Jan 14, 2022
Merged

Support KiND cluster for local dev environment #800 #2038

merged 21 commits into from
Jan 14, 2022

Conversation

robsondepaula
Copy link
Contributor

@robsondepaula robsondepaula commented Dec 10, 2021 •
edited by yaron2
Loading

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This is a WIP PR to address the lack of setup instructions for kubernetes clusters using KiND.

Issue reference

#800

@robsondepaula robsondepaula requested review from a team as code owners December 10, 2021 14:57
@robsondepaula robsondepaula mentioned this pull request Dec 10, 2021
Closed
2 tasks
@yaron2
Copy link
Member

yaron2 commented Dec 10, 2021

@robsondepaula see the failed links validation check - you should probably mark localhost:9999 as markdown localhost:9999.

@robsondepaula robsondepaula changed the title [WIP]Support KiND cluster for local dev environment #800 Support KiND cluster for local dev environment #800 Dec 12, 2021
@robsondepaula
Copy link
Contributor Author

@yaron2 it is fixed, thanks for the feedback.

@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 20, 2021
@msfussell msfussell self-requested a review December 24, 2021 18:20
@msfussell
Copy link
Member

@robsondepaula - Taking a look at this and just going through the steps to validate

@msfussell msfussell removed the stale label Dec 24, 2021
Antonio Robson de Paula and others added 15 commits December 30, 2021 09:16
[WIP]Support KiND cluster for local dev environment dapr#800
9d03a91 
Signed-off-by: Antonio Robson de Paula <[email protected]>
Fix for the failed link validation.
a2e555e 
Signed-off-by: Antonio Robson de Paula <[email protected]>
@greenie-msft
Add DCO check to PR template
79cdfa0 
Signed-off-by: Nick Greenfield <[email protected]>
Signed-off-by: Antonio Robson de Paula <[email protected]>
@greenie-msft
Added DCO sign-off guidance for contributing to Dapr
9e385d6 
Signed-off-by: Nick Greenfield <[email protected]>
Signed-off-by: Antonio Robson de Paula <[email protected]>
@greenie-msft
Address PR feedback
471e4f7 
Signed-off-by: Nick Greenfield <[email protected]>
Signed-off-by: Antonio Robson de Paula <[email protected]>
@willtsai
simplify git command for DCO
9d9c723 
Signed-off-by: Will Tsai <[email protected]>
Signed-off-by: Antonio Robson de Paula <[email protected]>
@AaronCrawfis
Fix header
79213c1 
Signed-off-by: Antonio Robson de Paula <[email protected]>
@findmyway @greenie-msft
Display state value instead of StateResponse object (dapr#2046)
eea015b 
Signed-off-by: Jun Tian <[email protected]>

Co-authored-by: greenie-msft <[email protected]>
Signed-off-by: Antonio Robson de Paula <[email protected]>
@rainfd @greenie-msft
add ForcePathStyle support for s3 binding (dapr#2054)
33cc1db 
Signed-off-by: rainfd <[email protected]>

Co-authored-by: greenie-msft <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Antonio Robson de Paula <[email protected]>
@chethanuk @greenie-msft @yaron2
Remove requests dep (dapr#2055)
f17e08a 
* Add DCO check to PR template

Signed-off-by: Nick Greenfield <[email protected]>

* Remove requests dep

Signed-off-by: GitHub <[email protected]>

Co-authored-by: Nick Greenfield <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Antonio Robson de Paula <[email protected]>
@lizzzcai
update endpoint in s3 binding doc (dapr#2049)
f91089b 
* update endpoint in s3 binding doc

Signed-off-by: lizzzcai <[email protected]>

* fix jaeger link

Signed-off-by: lizzzcai <[email protected]>

* update endpoint example to match region

Signed-off-by: lizzzcai <[email protected]>

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Antonio Robson de Paula <[email protected]>
@acartcat @greenie-msft
Update autoscale-keda.md (dapr#2047)
6ef0df0 
Co-authored-by: greenie-msft <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Antonio Robson de Paula <[email protected]>
@shriroopjoshi @greenie-msft
Update service-mesh.md (dapr#2044)
2f2cf08 
Minor typo

Co-authored-by: greenie-msft <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Antonio Robson de Paula <[email protected]>
@hoffe86
Added missing HTTP verb to the documentation dapr/dapr#4030 (dapr#2045)
2a9c3de 
Signed-off-by: GitHub <[email protected]>

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Antonio Robson de Paula <[email protected]>
@doggy8088 @yaron2
Update logs-troubleshooting.md (dapr#2023)
6dbf389 
The label name `dapr-placement` has been changed to `dapr-placement-server`.

Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Antonio Robson de Paula <[email protected]>
msfussell and others added 4 commits December 30, 2021 09:16
@msfussell
update the DOTNET SDK
92d1786 
Signed-off-by: Mark Fussell <[email protected]>
Signed-off-by: Antonio Robson de Paula <[email protected]>
@msfussell
updating SDK
c166eea 
Signed-off-by: Mark Fussell <[email protected]>
Signed-off-by: Antonio Robson de Paula <[email protected]>
@greenie-msft
Update daprdocs/content/en/operations/hosting/kubernetes/cluster/setu…
7651e66 
…p-kind.md

Co-authored-by: greenie-msft <[email protected]>
Signed-off-by: Antonio Robson de Paula <[email protected]>
@greenie-msft
Update daprdocs/content/en/operations/hosting/kubernetes/cluster/setu…
04ab8fb 
…p-kind.md

Co-authored-by: greenie-msft <[email protected]>
Signed-off-by: Antonio Robson de Paula <[email protected]>
@greenie-msft greenie-msft linked an issue Dec 30, 2021 that may be closed by this pull request
Support KiND cluster for local dev environment #800
Closed
2 tasks
@github-actions
Copy link

github-actions bot commented Jan 5, 2022

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jan 5, 2022
@github-actions github-actions bot closed this Jan 13, 2022
@msfussell msfussell reopened this Jan 13, 2022
@msfussell msfussell removed the stale label Jan 13, 2022
@greenie-msft
Copy link
Collaborator

Tested e2e. Looks good to me.

msfussell
msfussell approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greenie-msft greenie-msft merged commit 40122cc into dapr:v1.5 Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell msfussell approved these changes

@greenie-msft greenie-msft greenie-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support KiND cluster for local dev environment