Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Ftr: configuration store docs #1860

Closed
wants to merge 3 commits into from

Conversation

LaurenceLiZhixin
Copy link

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

@LaurenceLiZhixin LaurenceLiZhixin requested review from a team as code owners October 18, 2021 05:12
@msfussell
Copy link
Member

msfussell commented Oct 20, 2021

@LaurenceLiZhixin - Can you add a link to the code PR for these docs. We will need to review both of these together to get the docs to be correct, since this will be a significant update to the docs.

Please confirm is it these PRs from this Issue dapr/dapr#2988

@LaurenceLiZhixin - The docs will need much more information than in this current PR, including

  • Conceptual - What you have started here, but more information on why this API is useful including scenario use cases.
  • A HowTo use the API - with a walk through with code examples for different languages
  • Reference for the API documentation as per the other Dapr APIs here https://docs.dapr.io/reference/api/

I am happy to work with you on this.

@msfussell msfussell added this to the 1.5 milestone Oct 20, 2021
@greenie-msft greenie-msft modified the milestones: 1.5, 1.6 Oct 28, 2021
@LaurenceLiZhixin
Copy link
Author

@LaurenceLiZhixin - Can you add a link to the code PR for these docs. We will need to review both of these together to get the docs to be correct, since this will be a significant update to the docs.

Please confirm is it these PRs from this Issue dapr/dapr#2988

@LaurenceLiZhixin - The docs will need much more information than in this current PR, including

  • Conceptual - What you have started here, but more information on why this API is useful including scenario use cases.
  • A HowTo use the API - with a walk through with code examples for different languages
  • Reference for the API documentation as per the other Dapr APIs here https://docs.dapr.io/reference/api/

I am happy to work with you on this.

Yeah, the prs you showed is related to this feature. I would be very grateful if you can help me improve the documentation. @msfussell

@willtsai willtsai mentioned this pull request Nov 9, 2021
26 tasks
@greenie-msft
Copy link
Collaborator

Closing this issue in favor of #1959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants