-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add config api #3606
feat: add config api #3606
Conversation
@LaurenceLiZhixin notice the checks are failing |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
67d970c
to
daec9aa
Compare
I updated this pr and It's able to be reviewed I think. @artursouza |
a0c651b
to
0aa0a48
Compare
Codecov Report
@@ Coverage Diff @@
## master #3606 +/- ##
==========================================
- Coverage 62.93% 62.49% -0.44%
==========================================
Files 100 101 +1
Lines 9421 9525 +104
==========================================
+ Hits 5929 5953 +24
- Misses 3026 3107 +81
+ Partials 466 465 -1
Continue to review full report at Codecov.
|
The tests passed. @artursouza |
@LaurenceLiZhixin still fail. |
Could you please restart the e2e test again? I guess this problem is not my fault that caused it. And the previous commit can pass all tests. |
@LaurenceLiZhixin Please ensure resolve all comments. |
Done @daixiang0 |
Thanks @LaurenceLiZhixin resolve conflicts please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Cool! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Issue reference
Please reference the issue this PR will close: #2988
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: