Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash involving PanelTile.updateVoxelShape #133

Closed
sreegs-ahuj9 opened this issue Feb 11, 2024 · 5 comments
Closed

Crash involving PanelTile.updateVoxelShape #133

sreegs-ahuj9 opened this issue Feb 11, 2024 · 5 comments

Comments

@sreegs-ahuj9
Copy link

sreegs-ahuj9 commented Feb 11, 2024 •
edited
Loading

Hi there, we're encountering a crash on our server. Looks like a null exception involving concurrent access on a hashmap based on the line of the crash. Unfortunately I don't know much minecraft or java concurrency or else I'd just make a PR. I've attached a crash report
crash-2024-02-11_13.12.46-client.txt

We're running MC 1.20.1 via curseforge, also Create. The crash happens when a Create train activates a tiny redstone block with a panel.
@dannydjdk
Copy link
Owner

Thanks for the report! I have a few questions.

This looks like a client side crash. Is the server also crashing?

According to the log, it looks like Create might be trying to do something with the VoxelShape at the same time that Tiny Redstone is attempting to update it. When you say "activates", do you mean it's just giving it a redstone signal, or is it trying to make it apart of a contraption?

Does this happen intermittently, or is it consistently repeatable?

@sreegs-ahuj9
Copy link
Author

When it gives it a redstone signal. Someone was using a Tiny Redstone component in a circuit that is activated when a train trips a train signal, which sends out a redstone pulse.

It did not crash the server, just the client, and it happened consistently

@dannydjdk
Copy link
Owner

dannydjdk commented Mar 17, 2024 •
edited
Loading

I've posted a new version of the mod that will hopefully fix this issue (https://www.curseforge.com/minecraft/mc-mods/tiny-redstone/files/5189392). I can't verify 100%, because I was unable to reproduce, and the crash report appears to be incorrect about the line number where the crash occurs. There is no iterating happening at that point. I made some adjustments to that function where iteration is actually happening.

If you could test with this version and let me know what happens, I would be most grateful!

@sreegs-ahuj9
Copy link
Author

Thank you! I'll install the update on our server and report back if we still get the crash.

@dannydjdk dannydjdk mentioned this issue Apr 23, 2024
Open
dannydjdk added a commit that referenced this issue May 5, 2024
@dannydjdk
-1.19.2 Backport fix to prevent concurrent modification exception whe…
897f31a 
…n updating voxel shapes(#133).

-Fix issue with persistent redstone signal on panel of different orientation if one panel is removed.
-Make silicon compound recipe shapeless (#122) and allow any sand.
-added tinyredstone:redstone_panel to list of blocks to treat as wires to prevent blocks of different orientations from causing orphaned signals (#123).
@dannydjdk
Copy link
Owner

Fix back-ported to 1.19.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dannydjdk @sreegs-ahuj9