Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.19.2 Voxel shape crash from Tiny Redstone in a Create Clockwork modpack. #134

Open
Wazzah555 opened this issue Apr 22, 2024 · 7 comments
Labels
duplicate This issue or pull request already exists

Comments

@Wazzah555
Copy link

Wazzah555 commented Apr 22, 2024

I was using Minecraft Create Clockwork, a mod that allows for free physics vehicles, along with tiny redstone. I designed a tiny HUD display that would change based on redstone signals derived from the rotor. I initially made a very simple prototype that had no issues. However, when I fleshed out the helicopter design, and made a full body, suddenly for no apparent reason the voxel shape crashing issue surfaced. Whenever the states within the HUD circuitry were affected the game would immediately freeze and then crash. The same crash report would then come up detailing a create/ voxel shape issue. I really hope there's some way around this, as I have a lot of hours into this project and I'd hate to have all that effort be wasted.

Here is a video of the protoype project, which was completely fine. https://youtu.be/_t-mHWmXGmw

Here's the crash report: crash-2024-04-22_17.17.23-client.txt

@dannydjdk dannydjdk added the duplicate This issue or pull request already exists label Apr 23, 2024
@dannydjdk
Copy link
Owner

Duplicate of #133.
Thanks for the report! Please follow #133. This bug was fixed in the latest 1.20.2 version, but it looks like I'll need to backport that fix. Hope to have that fix out within the next couple days.

@Wazzah555
Copy link
Author

Thank you so much I really appreciate the fast response. Looking forward to it.

@dannydjdk
Copy link
Owner

@Wazzah555 Sorry, it took longer for me to get to this than expected, but it should be fixed now. If you could verify in #133 whether the updated fixes the issue for you, it would be appreciated.

@Wazzah555
Copy link
Author

Wazzah555 commented May 5, 2024

Thank you so much! Really appreciate your support of the mod. I'll give it a test and let you know if it worked. Where can I access the updated mod?

@Wazzah555
Copy link
Author

Hi, sorry for the late follow up. Hope you are doing well. I wanted to test for a while before I responded. Thanks again for taking the time to address my voxel shape issue. The fix definitely worked, voxel shape crashes barely happen at all, though the issue seems to not be totally gone. One thing to note, It hasn't really occurred since I deleted the redstone that was originally causing the crash. Attached is one of the crash reports I got after updating to the hotfix.

crash-2024-05-06_00.03.27-client.txt

Here's a quick showcase of the tiny redstone HUD I was to setting up to fly a create clockwork helicopter.
https://www.youtube.com/watch?v=aO3x08hF2kA

@dannydjdk
Copy link
Owner

Ah ok. That's a new crash, but also related to concurrent calling of the function to redraw voxel shapes. It's likely an extremely rare race condition that would cause that. However, I am going to make sure that function is fully thread safe to prevent any future issues.

@dannydjdk dannydjdk reopened this May 14, 2024
@Wazzah555
Copy link
Author

Thanks so much I appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants