Skip to content

Fix is_set for optional proto3 fields #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abn merged 6 commits into from
Apr 23, 2022
Merged

Fix is_set for optional proto3 fields #361

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9260a93
Fix is_set for optional proto3 fields
Gobot1234 Mar 28, 2022
ded7169
Format
Gobot1234 Mar 28, 2022
c8e611d
optional is False not None?
Gobot1234 Apr 21, 2022
707269a
Add a test
Gobot1234 Apr 22, 2022
5db524d
Add a test for the normal case
Gobot1234 Apr 23, 2022
fb01578
Update tests/test_features.py
Gobot1234 Apr 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/betterproto/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1317,7 +1317,12 @@ def is_set(self, name: str) -> bool:
:class:`bool`
`True` if field has been set, otherwise `False`.
"""
return self.__raw_get(name) is not PLACEHOLDER
default = (
PLACEHOLDER
if not self._betterproto.meta_by_field_name[name].optional
else None
)
return self.__raw_get(name) is not default


def serialized_on_wire(message: Message) -> bool:
Expand Down