Fix is_set for optional proto3 fields #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cetanu
previously approved these changes
Apr 21, 2022
abn
reviewed
Apr 22, 2022
Collaborator
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
Should this add a test case to prevent regression?
abn
reviewed
Apr 23, 2022
Co-authored-by: Arun Babu Neelicattu <[email protected]>
abn
approved these changes
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just occured to me that this was broken, realistically however this is easy enough for the end user to perform.