Skip to content

Remove imports if possible #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gobot1234 wants to merge 2 commits into from
Closed

Remove imports if possible #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f89976
Fix imports
Gobot1234 Jan 16, 2021
2c2a51a
Black
Gobot1234 Jan 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/betterproto/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

from ._types import T
from .casing import camel_case, safe_snake_case, snake_case
from .grpc.grpclib_client import ServiceStub
from .grpc import ServiceBase, ServiceStub

if sys.version_info[:2] < (3, 7):
# Apply backport of datetime.fromisoformat from 3.7
Expand Down
2 changes: 2 additions & 0 deletions src/betterproto/grpc/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
from .grpclib_client import ServiceStub
from .grpclib_server import ServiceBase
3 changes: 1 addition & 2 deletions src/betterproto/templates/template.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ from typing import {% for i in output_file.typing_imports|sort %}{{ i }}{% if no
{% endif %}

import betterproto
from betterproto.grpc.grpclib_server import ServiceBase
{% if output_file.services %}
import grpclib
{% endif %}
Expand Down Expand Up @@ -156,7 +155,7 @@ class {{ service.py_name }}Stub(betterproto.ServiceStub):
{% endfor %}

{% for service in output_file.services %}
class {{ service.py_name }}Base(ServiceBase):
class {{ service.py_name }}Base(betterproto.ServiceBase):
{% if service.comment %}
{{ service.comment }}

Expand Down