Remove imports if possible #196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I'm sorry to say so but I don't think this change is desirable, because it will make it harder (that is an even more breaking change) to allow grpclib to be an optional dependency. The reason this is an issue is that currently most of the weight of betterproto (in terms of memory usage and import time) is due to the root package depending on grpclib. This is unfortunate given that many users don't benefit from this dependency. |
Collaborator
Author
|
Makes sense, but from what I can remember the import is put in by default, so I'll have to have update the template to fix this I would assume? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does a bit of work over #170 to make generated code more consistent with betterproto.ServiceStub