Fixes for Python 3.9 #140
Fixes for Python 3.9 #140
Conversation
|
Looks like the new CI config doesn't work? |
|
Yeah I'm not too sure what's up with it |
|
Looks like it's been fixed, I take it back |
|
Not a clue what to do about this |
# Conflicts: # poetry.lock # pyproject.toml
|
Can we cherry pick the actual fix to merged and leave the tests as a separate PR to be merged once 3.9 plays better? |
|
Building wheels for dependencies seems like an impossible task in actions. |
nat-n
left a comment
nat-n
left a comment
There was a problem hiding this comment.
Why is the lockfile changed here?
|
It was due to me experimenting with checking system platform specific dependencies. |
>>> import typing
>>> def func(t: typing.List[str]):
... pass
...
>>> typing.get_type_hints(func)["t"]
typing.List[str]
>>> type(typing.get_type_hints(func)["t"])
<class 'typing._GenericAlias'>
>>> type(typing.List)
<class 'typing._SpecialGenericAlias'>
>>> type(typing.List) is type(typing.get_type_hints(func)["t"])
FalseI think this is the actual bug. |
nat-n
left a comment
nat-n
left a comment
There was a problem hiding this comment.
Why is the lockfile changed here?
It was due to me experimenting with checking system platform specific dependencies.
Better not to update the lockfile in this change if there's no good reason to do so.
|
Should be ready to go now :) |
Fix issue in logic for evaluating field types affecting python 3.9
2 participants
type(field_type)can now be<class 'list'>breaking the old method of checking.