-
Notifications
You must be signed in to change notification settings - Fork 229
Speedups #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Speedups #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nat-n
previously approved these changes
Aug 16, 2020
Collaborator
|
Some reasonable micro/-optimisations. This should get the code a little closer to being lintable without much trauma. |
cetanu
reviewed
Aug 17, 2020
nat-n
reviewed
Aug 18, 2020
nat-n
reviewed
Aug 29, 2020
Collaborator
|
Looks good, just need to rebase? |
Collaborator
Author
|
Do I? |
Collaborator
I'm guessing that would fix the CI run. |
Collaborator
Author
|
It's just from the black PR and the format changing. |
nat-n
approved these changes
Aug 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some speedups/memory improvements to the internals