Skip to content

Restored v prefix on published docker image tags #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielemery merged 1 commit into from
Jun 26, 2026
+10 −7
Merged

Restored v prefix on published docker image tags #578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/release-candidate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,11 @@ jobs:
with:
context: .
push: true
tags: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ needs.version.outputs.version }}
# Tag with the v-prefixed `tag` (e.g. v1.3.0-rc.0), not bare `version`: the helm chart and
# operators pin `api.version` to a vX.Y.Z string (CONTRIBUTING "Operator rules"), so the
# published image tag must carry the v. (The bare `version`/`base-version` are still used
# for the runtime/Sentry version below.)
tags: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ needs.version.outputs.tag }}
build-args: |
IMAGE_VERSION=${{ needs.version.outputs.base-version }}

Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/release-stable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,11 @@ jobs:
- name: Retag prerelease image as stable
env:
RC_TAG: ${{ inputs.prerelease_version }}
STABLE: ${{ needs.pre_release.outputs.release-version }}
STABLE_TAG: ${{ needs.pre_release.outputs.release-tag }}
run: |
RC="${RC_TAG#v}"
docker buildx imagetools create \
--tag "${REGISTRY}/${IMAGE_NAME}:${STABLE}" \
"${REGISTRY}/${IMAGE_NAME}:${RC}"
--tag "${REGISTRY}/${IMAGE_NAME}:${STABLE_TAG}" \
"${REGISTRY}/${IMAGE_NAME}:${RC_TAG}"

helm-stable:
needs: pre_release
Expand Down Expand Up @@ -159,11 +158,11 @@ jobs:

- name: Point latest at the stable image
env:
STABLE: ${{ needs.pre_release.outputs.release-version }}
STABLE_TAG: ${{ needs.pre_release.outputs.release-tag }}
run: |
docker buildx imagetools create \
--tag "${REGISTRY}/${IMAGE_NAME}:latest" \
"${REGISTRY}/${IMAGE_NAME}:${STABLE}"
"${REGISTRY}/${IMAGE_NAME}:${STABLE_TAG}"

post_release:
needs:
Expand Down