Skip to content

Restored v prefix on published docker image tags - #578

Merged
danielemery merged 1 commit into
mainfrom
hotfix-image-tag-prefix
Jun 26, 2026
Merged

danielemery merged 1 commit into
mainfrom
hotfix-image-tag-prefix

Conversation

@danielemery

@danielemery danielemery commented Jun 26, 2026 •

Copy link
Copy Markdown
Owner

The versioning rework switched the published image tag from the
v-prefixed git tag to the bare semver version, but the helm chart and
operators still pin api.version to a vX.Y.Z string (CONTRIBUTING
"Operator rules"), so deploys would hit ImagePullBackOff.

Tag the rc image from the v-prefixed tag output, and retag the stable
and latest images from the v-prefixed release-tag (dropping the prefix
strip), matching the pre-rework behaviour. Chart version, appVersion and
the Sentry release stay bare semver as before.

Co-Authored-By: Claude noreply@anthropic.com

Summary by CodeRabbit

  • Bug Fixes
    • Updated Docker image tagging so release-candidate builds are published with the expected vX.Y.Z-rc.N tag format.
    • Improved stable and latest image promotion to use the correct release tag, helping ensure downstream systems pull the intended artifact.

The versioning rework switched the published image tag from the
v-prefixed git tag to the bare semver version, but the helm chart and
operators still pin api.version to a vX.Y.Z string (CONTRIBUTING
"Operator rules"), so deploys would hit ImagePullBackOff.

Tag the rc image from the v-prefixed `tag` output, and retag the stable
and latest images from the v-prefixed `release-tag` (dropping the prefix
strip), matching the pre-rework behaviour. Chart version, appVersion and
the Sentry release stay bare semver as before.

Co-Authored-By: Claude <noreply@anthropic.com>
@danielemery danielemery added the semver:patch A PR with this label will trigger a patch semver bump label Jun 26, 2026
@coderabbitai

coderabbitai Bot commented Jun 26, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 595bbdf1-2171-47a9-9c9b-352ccde19b8d

📥 Commits

Reviewing files that changed from the base of the PR and between 0e13046 and a818013.

📒 Files selected for processing (2)
  • .github/workflows/release-candidate.yml
  • .github/workflows/release-stable.yml

📝 Walkthrough

Walkthrough

The release-candidate workflow now publishes Docker images with the prerelease v-prefixed tag. The release-stable workflow now retags both the stable manifest and latest from the promoted release-tag output.

Changes

Release tagging updates

Layer / File(s) Summary
Prerelease publish tag
.github/workflows/release-candidate.yml
The Docker publish step now uses needs.version.outputs.tag and adds comments about the required v-prefixed prerelease tag.
Stable promotion tags
.github/workflows/release-stable.yml
retag-image and retag-latest now use needs.pre_release.outputs.release-tag when creating the stable manifest and latest reference.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

I hopped through tags from burrow to sky,
With v-prefixed crumbs for images to fly.
The stable moon turned latest bright,
And RC carrots lined up just right. 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: restoring the v-prefixed Docker image tags.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix-image-tag-prefix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.30%. Comparing base (0e13046) to head (a818013).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #578   +/-   ##
=======================================
  Coverage   36.30%   36.30%           
=======================================
  Files          28       28           
  Lines         942      942           
  Branches      188      188           
=======================================
  Hits          342      342           
  Misses        548      548           
  Partials       52       52           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielemery
danielemery merged commit 6b4e31f into main Jun 26, 2026
8 checks passed
@danielemery
danielemery deleted the hotfix-image-tag-prefix branch June 26, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patch A PR with this label will trigger a patch semver bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants