Repository navigation
Restored v prefix on published docker image tags - #578
Conversation
The versioning rework switched the published image tag from the v-prefixed git tag to the bare semver version, but the helm chart and operators still pin api.version to a vX.Y.Z string (CONTRIBUTING "Operator rules"), so deploys would hit ImagePullBackOff. Tag the rc image from the v-prefixed `tag` output, and retag the stable and latest images from the v-prefixed `release-tag` (dropping the prefix strip), matching the pre-rework behaviour. Chart version, appVersion and the Sentry release stay bare semver as before. Co-Authored-By: Claude <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe release-candidate workflow now publishes Docker images with the prerelease ChangesRelease tagging updates
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
=======================================
Coverage 36.30% 36.30%
=======================================
Files 28 28
Lines 942 942
Branches 188 188
=======================================
Hits 342 342
Misses 548 548
Partials 52 52 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The versioning rework switched the published image tag from the
v-prefixed git tag to the bare semver version, but the helm chart and
operators still pin api.version to a vX.Y.Z string (CONTRIBUTING
"Operator rules"), so deploys would hit ImagePullBackOff.
Tag the rc image from the v-prefixed
tagoutput, and retag the stableand latest images from the v-prefixed
release-tag(dropping the prefixstrip), matching the pre-rework behaviour. Chart version, appVersion and
the Sentry release stay bare semver as before.
Co-Authored-By: Claude noreply@anthropic.com
Summary by CodeRabbit
vX.Y.Z-rc.Ntag format.latestimage promotion to use the correct release tag, helping ensure downstream systems pull the intended artifact.