Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark test_server_info as xfailing #978

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Mark test_server_info as xfailing #978

merged 1 commit into from
Apr 21, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Apr 21, 2022

Closes #976.

@jwodder jwodder added the tests Add or improve existing tests label Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #978 (a30eeac) into master (431a533) will increase coverage by 24.49%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #978       +/-   ##
===========================================
+ Coverage   63.08%   87.57%   +24.49%     
===========================================
  Files          65       65               
  Lines        8023     8111       +88     
===========================================
+ Hits         5061     7103     +2042     
+ Misses       2962     1008     -1954     
Flag Coverage Δ
unittests 87.57% <100.00%> (+24.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/test_utils.py 97.29% <100.00%> (+65.32%) ⬆️
dandi/upload.py 85.85% <0.00%> (+0.07%) ⬆️
dandi/delete.py 90.96% <0.00%> (+0.70%) ⬆️
dandi/dandiset.py 83.13% <0.00%> (+1.20%) ⬆️
dandi/_version.py 45.96% <0.00%> (+2.14%) ⬆️
dandi/cli/cmd_shell_completion.py 32.00% <0.00%> (+2.83%) ⬆️
dandi/files.py 78.66% <0.00%> (+3.06%) ⬆️
dandi/dandiapi.py 88.28% <0.00%> (+3.08%) ⬆️
dandi/tests/test_delete.py 100.00% <0.00%> (+3.68%) ⬆️
dandi/misctypes.py 61.68% <0.00%> (+6.24%) ⬆️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 431a533...a30eeac. Read the comment docs.

@yarikoptic yarikoptic merged commit c67a68d into master Apr 21, 2022
@yarikoptic yarikoptic deleted the gh-976 branch April 21, 2022 17:45
@github-actions
Copy link

🚀 PR was released in 0.39.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_server_info failing due to no good version provided
2 participants