-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_server_info failing due to no good version provided #976
Comments
@yarikoptic That test is not run against the local Docker setup. The references to Docker in the test's code are for the integration tests with the old redirector. |
so you think test would pass after dandi/dandi-archive#1054 merged/deployed? since placing into production would take time, should we just for now mark it as xfail and then reenable after deployed? |
Yes.
You tell me. |
if you have no opinion, then let's indeed proceed with mine of xfail. |
Mark `test_server_info` as xfailing
🚀 Issue was released in |
now that there is no redirector with hardcoded version and version is reported of dandi-archive itself we hit good old dandi/dandi-archive#222 leading to
dandi/dandi-archive#1054 might be the one to resolve it for the main deployments but I don't know if it would apply to our dockerized server testing since it hardcodes to 0.0.0 in https://github.com/dandi/dandi-archive/pull/1054/files#diff-8fbdfcdd92c90a7625fcf215e3b363869ff8ce725869824d28380b863498d35dR14
The text was updated successfully, but these errors were encountered: