Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): new settings migration utility for evolutions #214

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

NPavie
Copy link
Collaborator

@NPavie NPavie commented Apr 11, 2024

Introducing a setting migrator to allow safer changes of settings across versions when changes are required
(like merging or splitting settings)

A first migrator is provided to migrate current settings to a new version, including :

Introducing a setting migrator to allow a safer changes of settings
across versions when changes are required
(like merging or splitting settings)

A first migrator is provided to migrate current settings to a new
version, including :
- merging the action setting for jobs and app on closing the main
window (see #129)
- Adding a new setting to control if a job edition should be done in
place or in a new job page (to prepare #130)
- cleaning up pipeline instance properties stored in settings
@marisademeglio
Copy link
Member

This will also be helpful for #169 and #170

@marisademeglio
Copy link
Member

This is the first time I've tried the new merged settings and this is what I see for each option when there is a completed job open:

  1. keep all jobs open...: closes the window and keeps the job via tray icon
  2. close all jobs...: displays the "jobs will be removed" warning, then I say "proceed", then it closes the window and the job, and the tray icon is there but with no jobs
  3. quit the application: quits the application
  4. ask each time: asks each time

It makes sense and also it seems to have migrated my old setting correctly.

@marisademeglio marisademeglio merged commit 41643d5 into main Apr 15, 2024
@bertfrees bertfrees deleted the issue-129 branch April 17, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants