Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the two settings related to window closing #129

Closed
bertfrees opened this issue Mar 16, 2023 · 4 comments
Closed

Merge the two settings related to window closing #129

bertfrees opened this issue Mar 16, 2023 · 4 comments
Labels
propose-to-close
Milestone
v1.3

Comments

@bertfrees
Copy link
Member

The options would be:

  • Quit the application
  • Keep the application running in the tray and keep all jobs open
  • Keep the application running in the tray and close all non-running jobs
  • Ask when closing the window
@bertfrees bertfrees mentioned this issue Mar 16, 2023
Closed
@NPavie
Copy link
Collaborator

NPavie commented Mar 17, 2023

Should the dialog linked to this be changed too to reflect this merge ?

@bertfrees
Copy link
Member Author

Yes, I think so. There may be other dialogs too that may unclude (some of the) options. See in this regard also #83 (comment).

@marisademeglio marisademeglio mentioned this issue Mar 17, 2023
Closed
NPavie added a commit that referenced this issue Mar 21, 2023
@NPavie
fix(#129): merged settings for closing window
b548594 
Also includes
- a settings migrator to migrate settings
from previous version of the app
- a cleanup of pipeline properties stored in settings
  - type of pipeline is added in property for later use
- a cleanup of pipeline ipc with removal of unused functions
@bertfrees
Copy link
Member Author

@NPavie I see you created a feature branch for this issue, but it has not been merged?

@NPavie
Copy link
Collaborator

NPavie commented Apr 10, 2024

I started working on it but it was put in stand by.
it should not take me tool long to update and merge.

NPavie added a commit that referenced this issue Apr 11, 2024
@NPavie
feat(settings): new settings migration utility for evolutions
ac6b01a 
Introducing a setting migrator to allow a safer changes of settings
across versions when changes are required
(like merging or splitting settings)

A first migrator is provided to migrate current settings to a new
version, including :
- merging the action setting for jobs and app on closing the main
window (see #129)
- Adding a new setting to control if a job edition should be done in
place or in a new job page (to prepare #130)
- cleaning up pipeline instance properties stored in settings
@NPavie NPavie mentioned this issue Apr 11, 2024
Merged
@bertfrees bertfrees mentioned this issue Apr 11, 2024
Closed
@bertfrees bertfrees added this to the v1.3 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
propose-to-close
Projects
Pipeline 2 | April 2024 release
Status: Done
Milestone
v1.3
Development

No branches or pull requests
3 participants
@marisademeglio @bertfrees @NPavie